<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
LGTM<br>
<div class="moz-forward-container">
<div><br>
NIT:<br>
lp$( echo $option_dist | sed 's#\.##g’ ).1.1 would be a little
more readable</div>
<div> </div>
<div data-signature-widget="container">
<div data-signature-widget="content">
<div>--<br>
Oleg Koshovetc</div>
</div>
</div>
<div> </div>
<div> </div>
<blockquote style="border-left:1px solid #0857A6; margin:10px;
padding:0 0 0 10px;">Пятница, 20 ноября 2020, 14:57 +03:00 от
Alexander Tikhonov <a class="moz-txt-link-rfc2396E" href="mailto:avtikhon@tarantool.org"><avtikhon@tarantool.org></a>:<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<div>
<div id="style_16058734331252035923_BODY">
<div class="cl_143838">
<div><br>
<br>
<br>
<span>-------- Пересылаемое сообщение --------<br>
От кого: Alexander V. Tikhonov <<a
href="/compose?To=avtikhon@tarantool.org"
moz-do-not-send="true">avtikhon@tarantool.org</a>><br>
Кому: Kirill Yukhin <<a
href="/compose?To=kyukhin@tarantool.org"
moz-do-not-send="true">kyukhin@tarantool.org</a>><br>
Копия: Alexander V. Tikhonov <<a
href="/compose?To=avtikhon@tarantool.org"
moz-do-not-send="true">avtikhon@tarantool.org</a>>,
<a
href="/compose?To=tarantool%2dpatches@dev.tarantool.org"
moz-do-not-send="true">tarantool-patches@dev.tarantool.org</a><br>
Дата: Воскресенье, 25 октября 2020, 11:37 +03:00<br>
Тема: [PATCH v1 3/3] update_repo: correct remove
routine<br>
</span>
<div>
<div class="js-helper_mr_css_attr
js-readmsg-msg_mr_css_attr">
<div>
<div
id="style_16036150681623719318_BODY_mr_css_attr">Implemented
ability to remove opensuse-leap OS packages.<br>
---<br>
tools/update_repo.sh | 11 ++++++++++-<br>
1 file changed, 10 insertions(+), 1
deletion(-)<br>
<br>
diff --git a/tools/update_repo.sh
b/tools/update_repo.sh<br>
index 0d39f108d..581539719 100755<br>
--- a/tools/update_repo.sh<br>
+++ b/tools/update_repo.sh<br>
@@ -881,7 +881,16 @@ function remove_rpm {<br>
# broken update left orphan files: they
are present in the<br>
# storage, but does not mentioned in
the metadata.<br>
for suffix in 'x86_64' 'noarch' 'src';
do<br>
-
file="$bucket_path/$packpath/${remove}-1.${os}${option_dist}.${suffix}.rpm"<br>
+ if [ "$os" == "opensuse-leap" ]; then<br>
+ # Open Build Service (openSUSE) does not
follow the usual<br>
+ # approach: 'Release' is like lp152.1.1,
where the first<br>
+ # '1' is $(RELEASE) RPM spec directive
value and the second<br>
+ # '1' is the number of rebuilds.<br>
+ os_dist="lp"`echo $option_dist | sed
's#\.##g'`".1.1"<br>
+ else<br>
+ os_dist="1.${os}${option_dist}"<br>
+ fi<br>
+
file="$bucket_path/$packpath/${remove}-${os_dist}.${suffix}.rpm"<br>
echo "Searching to remove: $file"<br>
$aws ls $file || continue<br>
$aws rm $file<br>
--<br>
2.25.1<br>
</div>
</div>
</div>
</div>
<hr>
<div> </div>
<div data-signature-widget="container">
<div data-signature-widget="content">
<div>--<br>
Alexander Tikhonov</div>
</div>
</div>
<div> </div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div> </div>
</div>
</body>
</html>