<HTML><BODY><div>LGTM.</div><div> </div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 20 августа 2020, 0:36 +03:00 от Cyrill Gorcunov <gorcunov@gmail.com>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15978729720918647882_BODY">Since we no longer use txn engine for synchro<br>packets processing this code is never executed.<br><br>Part-of #5129<br><br>Signed-off-by: Cyrill Gorcunov <<a href="/compose?To=gorcunov@gmail.com">gorcunov@gmail.com</a>><br>---<br> src/box/txn.c | 9 +--------<br> 1 file changed, 1 insertion(+), 8 deletions(-)<br><br>diff --git a/src/box/txn.c b/src/box/txn.c<br>index cc1f496c5..b2d342355 100644<br>--- a/src/box/txn.c<br>+++ b/src/box/txn.c<br>@@ -82,14 +82,7 @@ txn_add_redo(struct txn *txn, struct txn_stmt *stmt, struct request *request)<br> */<br> struct space *space = stmt->space;<br> row->group_id = space != NULL ? space_group_id(space) : 0;<br>- /*<br>- * Sychronous replication entries are supplementary and<br>- * aren't valid dml requests. They're encoded manually.<br>- */<br>- if (likely(!iproto_type_is_synchro_request(row->type)))<br>- row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);<br>- else<br>- row->bodycnt = xrow_header_dup_body(row, &txn->region);<br>+ row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);<br> if (row->bodycnt < 0)<br> return -1;<br> stmt->row = row;<br>--<br>2.26.2</div></div></div></div></blockquote><div>--<br>Serge Petrenko</div><div> </div></BODY></HTML>