<HTML><BODY><div><div>Also there are 4 places where tabs were replaced by spaces,</div><div>marked them below.</div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Вторник, 4 августа 2020, 12:55 +03:00 от Ilya Kosarev <i.kosarev@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15965349560039154080_BODY"><div class="cl_542798"><div><div>Hi!<br><br>Yes, this patch seems to be nice.</div><div> </div><div>See 1 comment below.</div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;">Понедельник, 13 июля 2020, 17:18 +03:00 от Aleksandr Lyapunov <<a href="/compose?To=alyapunov@tarantool.org">alyapunov@tarantool.org</a>>:<br> <div id=""><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><style type="text/css"></style><div><div id="style_15946499221980103863_BODY_mr_css_attr">We should use noexcept where it's appropriate.<br>1.It informs a developer he could not care about exception safety<br>2.It instructs a compiler to check throws if possible<br><br>We should override for compile-time check of misprints in names<br>of methods and types of arguments.<br><br>Part of #5153<br>---<br> src/box/alter.cc | 180 +++++++++++++++++++++++++++----------------------------<br> 1 file changed, 90 insertions(+), 90 deletions(-)<br><br>diff --git a/src/box/alter.cc b/src/box/alter.cc<br>index 249cee2..15a51d0 100644<br>--- a/src/box/alter.cc<br>+++ b/src/box/alter.cc<br>@@ -765,7 +765,7 @@ struct alter_space;<br> <br> class AlterSpaceOp {<br> public:<br>- AlterSpaceOp(struct alter_space *alter);<br>+ explicit AlterSpaceOp(struct alter_space *alter);<br> <br> /** Link in alter_space::ops. */<br> struct rlist link;<br>@@ -774,7 +774,7 @@ public:<br> * the space definition and/or key list that will be used<br> * for creating the new space. Must not yield or fail.<br> */<br>- virtual void alter_def(struct alter_space * /* alter */) {}<br>+ virtual void alter_def(struct alter_space * /* alter */) noexcept {}<br> /**<br> * Called after creating a new space. Used for performing<br> * long-lasting operations, such as index rebuild or format<br>@@ -788,21 +788,21 @@ public:<br> * state to the new space (e.g. move unchanged indexes).<br> * Must not yield or fail.<br> */<br>- virtual void alter(struct alter_space * /* alter */) {}<br>+ virtual void alter(struct alter_space * /* alter */) noexcept {}<br> /**<br> * Called after the change has been successfully written<br> * to WAL. Must not fail.<br> */<br> virtual void commit(struct alter_space * /* alter */,<br>- int64_t /* signature */) {}<br>+ int64_t /* signature */) noexcept {}<br> /**<br> * Called in case a WAL error occurred. It is supposed to undo<br> * the effect of AlterSpaceOp::prepare and AlterSpaceOp::alter.<br> * Must not fail.<br> */<br>- virtual void rollback(struct alter_space * /* alter */) {}<br>+ virtual void rollback(struct alter_space * /* alter */) noexcept {}<br> <br>- virtual ~AlterSpaceOp() {}<br>+ virtual ~AlterSpaceOp() noexcept {}<br> <br> void *operator new(size_t size)<br> {<br>@@ -984,7 +984,7 @@ struct mh_i32_t *AlterSpaceLock::registry;<br> * Replace the old space with a new one in the space cache.<br> */<br> static int<br>-alter_space_commit(struct trigger *trigger, void *event)<br>+alter_space_commit(struct trigger *trigger, void *event) noexcept<br> {<br> struct txn *txn = (struct txn *) event;<br> struct alter_space *alter = (struct alter_space *) trigger->data;<br>@@ -1002,12 +1002,8 @@ alter_space_commit(struct trigger *trigger, void *event)<br> * indexes into their new places.<br> */<br> class AlterSpaceOp *op;<br>- try {<br>- rlist_foreach_entry(op, &alter->ops, link)<br>- op->commit(alter, signature);<br>- } catch (Exception *e) {<br>- return -1;<br>- }<br>+ rlist_foreach_entry(op, &alter->ops, link)<br>+ op->commit(alter, signature);</div></div></div></div></blockquote></div><div>I guess this change should be in</div><div>«alter: do not catch exceptions when it's not necessary» commit.</div><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div> <br> alter->new_space = NULL; /* for alter_space_delete(). */<br> /*<br>@@ -1029,7 +1025,7 @@ alter_space_commit(struct trigger *trigger, void *event)<br> * alter_space_commit() failure (unlikely)<br> */<br> static int<br>-alter_space_rollback(struct trigger *trigger, void * /* event */)<br>+alter_space_rollback(struct trigger *trigger, void * /* event */) noexcept<br> {<br> struct alter_space *alter = (struct alter_space *) trigger->data;<br> /* Rollback alter ops */<br>@@ -1188,9 +1184,9 @@ alter_space_do(struct txn_stmt *stmt, struct alter_space *alter)<br> class CheckSpaceFormat: public AlterSpaceOp<br> {<br> public:<br>- CheckSpaceFormat(struct alter_space *alter)<br>+ explicit CheckSpaceFormat(struct alter_space *alter)<br> :AlterSpaceOp(alter) {}<br>- virtual void prepare(struct alter_space *alter);<br>+ void prepare(struct alter_space *alter) override;<br> };<br> <br> void<br>@@ -1222,15 +1218,15 @@ public:<br> * names into an old dictionary and deletes new one.<br> */<br> struct tuple_dictionary *new_dict;<br>- virtual void alter_def(struct alter_space *alter);<br>- virtual void alter(struct alter_space *alter);<br>- virtual void rollback(struct alter_space *alter);<br>- virtual ~ModifySpace();<br>+ void alter_def(struct alter_space *alter) noexcept override;<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br>+ ~ModifySpace() noexcept override;<br> };<br> <br> /** Amend the definition of the new space. */<br> void<br>-ModifySpace::alter_def(struct alter_space *alter)<br>+ModifySpace::alter_def(struct alter_space *alter) noexcept<br> {<br> /*<br> * Use the old dictionary for the new space, because<br>@@ -1249,7 +1245,7 @@ ModifySpace::alter_def(struct alter_space *alter)<br> }<br> <br> void<br>-ModifySpace::alter(struct alter_space *alter)<br>+ModifySpace::alter(struct alter_space *alter) noexcept<br> {<br> /*<br> * Move new names into an old dictionary, which already is<br>@@ -1260,12 +1256,12 @@ ModifySpace::alter(struct alter_space *alter)<br> }<br> <br> void<br>-ModifySpace::rollback(struct alter_space *alter)<br>+ModifySpace::rollback(struct alter_space *alter) noexcept<br> {<br> tuple_dictionary_swap(alter->new_space->def->dict, new_dict);<br> }<br> <br>-ModifySpace::~ModifySpace()<br>+ModifySpace::~ModifySpace() noexcept<br> {<br> if (new_dict != NULL)<br> tuple_dictionary_unref(new_dict);<br>@@ -1281,9 +1277,9 @@ public:<br> DropIndex(struct alter_space *alter, struct index *index)<br> :AlterSpaceOp(alter), old_index(index) {}<br> struct index *old_index;<br>- virtual void alter_def(struct alter_space *alter);<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t lsn);<br>+ void alter_def(struct alter_space *alter) noexcept override;<br>+ void prepare(struct alter_space *alter) override;<br>+ void commit(struct alter_space *alter, int64_t lsn) noexcept override;<br> };<br> <br> /*<br>@@ -1291,7 +1287,7 @@ public:<br> * the new index from it.<br> */<br> void<br>-DropIndex::alter_def(struct alter_space * /* alter */)<br>+DropIndex::alter_def(struct alter_space * /* alter */) noexcept<br> {<br> rlist_del_entry(old_index->def, link);<br> }<br>@@ -1305,7 +1301,7 @@ DropIndex::prepare(struct alter_space *alter)<br> }<br> <br> void<br>-DropIndex::commit(struct alter_space *alter, int64_t signature)<br>+DropIndex::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> (void)alter;<br> index_commit_drop(old_index, signature);<br>@@ -1323,18 +1319,18 @@ public:<br> :AlterSpaceOp(alter), iid(iid_arg) {}<br> /** id of the index on the move. */<br> uint32_t iid;<br>- virtual void alter(struct alter_space *alter);<br>- virtual void rollback(struct alter_space *alter);<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br> };<br> <br> void<br>-MoveIndex::alter(struct alter_space *alter)<br>+MoveIndex::alter(struct alter_space *alter) noexcept<br> {<br> space_swap_index(alter->old_space, alter->new_space, iid, iid);<br> }<br> <br> void<br>-MoveIndex::rollback(struct alter_space *alter)<br>+MoveIndex::rollback(struct alter_space *alter) noexcept<br> {<br> space_swap_index(alter->old_space, alter->new_space, iid, iid);<br> }<br>@@ -1365,23 +1361,23 @@ public:<br> struct index *old_index;<br> struct index *new_index;<br> struct index_def *new_index_def;<br>- virtual void alter_def(struct alter_space *alter);<br>- virtual void alter(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t lsn);<br>- virtual void rollback(struct alter_space *alter);<br>- virtual ~ModifyIndex();<br>+ void alter_def(struct alter_space *alter) noexcept override;<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void commit(struct alter_space *alter, int64_t lsn) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br>+ ~ModifyIndex() noexcept override;<br> };<br> <br> /** Update the definition of the new space */<br> void<br>-ModifyIndex::alter_def(struct alter_space *alter)<br>+ModifyIndex::alter_def(struct alter_space *alter) noexcept<br> {<br> rlist_del_entry(old_index->def, link);<br> index_def_list_add(&alter->key_list, new_index_def);<br> }<br> <br> void<br>-ModifyIndex::alter(struct alter_space *alter)<br>+ModifyIndex::alter(struct alter_space *alter) noexcept<br> {<br> new_index = space_index(alter->new_space, new_index_def->iid);<br> assert(old_index->def->iid == new_index->def->iid);<br>@@ -1397,14 +1393,14 @@ ModifyIndex::alter(struct alter_space *alter)<br> }<br> <br> void<br>-ModifyIndex::commit(struct alter_space *alter, int64_t signature)<br>+ModifyIndex::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> (void)alter;<br> index_commit_modify(new_index, signature);<br> }<br> <br> void<br>-ModifyIndex::rollback(struct alter_space *alter)<br>+ModifyIndex::rollback(struct alter_space *alter) noexcept<br> {<br> /*<br> * Restore indexes.<br>@@ -1416,7 +1412,7 @@ ModifyIndex::rollback(struct alter_space *alter)<br> index_update_def(old_index);<br> }<br> <br>-ModifyIndex::~ModifyIndex()<br>+ModifyIndex::~ModifyIndex() noexcept<br> {<br> index_def_delete(new_index_def);<br> }<br>@@ -1432,15 +1428,15 @@ public:<br> CreateIndex(struct alter_space *alter, struct index_def *def)<br> :AlterSpaceOp(alter), new_index(NULL), new_index_def(def)<br> {}<br>- virtual void alter_def(struct alter_space *alter);<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t lsn);<br>- virtual ~CreateIndex();<br>+ void alter_def(struct alter_space *alter) noexcept override;<br>+ void prepare(struct alter_space *alter) override;<br>+ void commit(struct alter_space *alter, int64_t lsn) noexcept override;<br>+ ~CreateIndex() noexcept override;<br> };<br> <br> /** Add definition of the new key to the new space def. */<br> void<br>-CreateIndex::alter_def(struct alter_space *alter)<br>+CreateIndex::alter_def(struct alter_space *alter) noexcept<br> {<br> index_def_list_add(&alter->key_list, new_index_def);<br> }<br>@@ -1480,7 +1476,7 @@ CreateIndex::prepare(struct alter_space *alter)<br> }<br> <br> void<br>-CreateIndex::commit(struct alter_space *alter, int64_t signature)<br>+CreateIndex::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> (void) alter;<br> assert(new_index != NULL);<br>@@ -1488,7 +1484,7 @@ CreateIndex::commit(struct alter_space *alter, int64_t signature)<br> new_index = NULL;<br> }<br> <br>-CreateIndex::~CreateIndex()<br>+CreateIndex::~CreateIndex() noexcept<br> {<br> if (new_index != NULL)<br> index_abort_create(new_index);<br>@@ -1521,15 +1517,15 @@ public:<br> struct index_def *new_index_def;<br> /** Old index index_def. */<br> struct index_def *old_index_def;<br>- virtual void alter_def(struct alter_space *alter);<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t signature);<br>- virtual ~RebuildIndex();<br>+ void alter_def(struct alter_space *alter) noexcept override;<br>+ void prepare(struct alter_space *alter) override;<br>+ void commit(struct alter_space *alter, int64_t signature) noexcept override;<br>+ ~RebuildIndex() noexcept override;<br> };<br> <br> /** Add definition of the new key to the new space def. */<br> void<br>-RebuildIndex::alter_def(struct alter_space *alter)<br>+RebuildIndex::alter_def(struct alter_space *alter) noexcept<br> {<br> rlist_del_entry(old_index_def, link);<br> index_def_list_add(&alter->key_list, new_index_def);<br>@@ -1545,7 +1541,7 @@ RebuildIndex::prepare(struct alter_space *alter)<br> }<br> <br> void<br>-RebuildIndex::commit(struct alter_space *alter, int64_t signature)<br>+RebuildIndex::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> struct index *old_index = space_index(alter->old_space,<br> old_index_def->iid);<br>@@ -1556,7 +1552,7 @@ RebuildIndex::commit(struct alter_space *alter, int64_t signature)<br> new_index = NULL;<br> }<br> <br>-RebuildIndex::~RebuildIndex()<br>+RebuildIndex::~RebuildIndex() noexcept<br> {<br> if (new_index != NULL)<br> index_abort_create(new_index);<br>@@ -1600,9 +1596,10 @@ public:<br> TruncateIndex(struct alter_space *alter, uint32_t iid)<br> : AlterSpaceOp(alter), iid(iid),<br> old_index(NULL), new_index(NULL) {}<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t signature);<br>- virtual ~TruncateIndex();<br>+ void prepare(struct alter_space *alter) override;<br>+ void commit(struct alter_space *alter,<br>+ int64_t signature) noexcept override;</div></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div><ol><li>Here on a new line.</li></ol><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="cl_542798"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div>+ ~TruncateIndex() noexcept override;<br> };<br> <br> void<br>@@ -1632,7 +1629,7 @@ TruncateIndex::prepare(struct alter_space *alter)<br> }<br> <br> void<br>-TruncateIndex::commit(struct alter_space *alter, int64_t signature)<br>+TruncateIndex::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> (void)alter;<br> index_commit_drop(old_index, signature);<br>@@ -1640,7 +1637,7 @@ TruncateIndex::commit(struct alter_space *alter, int64_t signature)<br> new_index = NULL;<br> }<br> <br>-TruncateIndex::~TruncateIndex()<br>+TruncateIndex::~TruncateIndex() noexcept<br> {<br> if (new_index == NULL)<br> return;<br>@@ -1657,11 +1654,11 @@ class UpdateSchemaVersion: public AlterSpaceOp<br> public:<br> UpdateSchemaVersion(struct alter_space * alter)<br> :AlterSpaceOp(alter) {}<br>- virtual void alter(struct alter_space *alter);<br>+ void alter(struct alter_space *alter) noexcept override;<br> };<br> <br> void<br>-UpdateSchemaVersion::alter(struct alter_space *alter)<br>+UpdateSchemaVersion::alter(struct alter_space *alter) noexcept<br> {<br> (void)alter;<br> ++schema_version;<br>@@ -1684,10 +1681,10 @@ public:<br> RebuildCkConstraints(struct alter_space *alter) : AlterSpaceOp(alter),<br> ck_constraint(RLIST_HEAD_INITIALIZER(ck_constraint)) {}<br> struct rlist ck_constraint;<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void alter(struct alter_space *alter);<br>- virtual void rollback(struct alter_space *alter);<br>- virtual ~RebuildCkConstraints();<br>+ void prepare(struct alter_space *alter) override;<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br>+ ~RebuildCkConstraints() noexcept override;<br> };<br> <br> void<br>@@ -1716,18 +1713,18 @@ RebuildCkConstraints::space_swap_ck_constraint(struct space *old_space,<br> }<br> <br> void<br>-RebuildCkConstraints::alter(struct alter_space *alter)<br>+RebuildCkConstraints::alter(struct alter_space *alter) noexcept<br> {<br> space_swap_ck_constraint(alter->old_space, alter->new_space);<br> }<br> <br> void<br>-RebuildCkConstraints::rollback(struct alter_space *alter)<br>+RebuildCkConstraints::rollback(struct alter_space *alter) noexcept<br> {<br> space_swap_ck_constraint(alter->new_space, alter->old_space);<br> }<br> <br>-RebuildCkConstraints::~RebuildCkConstraints()<br>+RebuildCkConstraints::~RebuildCkConstraints() noexcept<br> {<br> struct ck_constraint *old_ck_constraint, *tmp;<br> rlist_foreach_entry_safe(old_ck_constraint, &ck_constraint, link, tmp) {<br>@@ -1754,8 +1751,8 @@ class MoveCkConstraints: public AlterSpaceOp<br> struct space *new_space);<br> public:<br> MoveCkConstraints(struct alter_space *alter) : AlterSpaceOp(alter) {}<br>- virtual void alter(struct alter_space *alter);<br>- virtual void rollback(struct alter_space *alter);<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br> };<br> <br> void<br>@@ -1769,13 +1766,13 @@ MoveCkConstraints::space_swap_ck_constraint(struct space *old_space,<br> }<br> <br> void<br>-MoveCkConstraints::alter(struct alter_space *alter)<br>+MoveCkConstraints::alter(struct alter_space *alter) noexcept<br> {<br> space_swap_ck_constraint(alter->old_space, alter->new_space);<br> }<br> <br> void<br>-MoveCkConstraints::rollback(struct alter_space *alter)<br>+MoveCkConstraints::rollback(struct alter_space *alter) noexcept<br> {<br> space_swap_ck_constraint(alter->new_space, alter->old_space);<br> }<br>@@ -1834,11 +1831,12 @@ public:<br> if (new_id == NULL)<br> diag_raise();<br> }<br>- virtual void prepare(struct alter_space *alter);<br>- virtual void alter(struct alter_space *alter);<br>- virtual void rollback(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter, int64_t signature);<br>- virtual ~CreateConstraintID();<br>+ void prepare(struct alter_space *alter) override;<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void rollback(struct alter_space *alter) noexcept override;<br>+ void commit(struct alter_space *alter,<br>+ int64_t signature) noexcept override;</div></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div><ol start="2"><li>Here on a new line.</li></ol><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="cl_542798"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div>+ ~CreateConstraintID() noexcept override;<br> };<br> <br> void<br>@@ -1850,7 +1848,7 @@ CreateConstraintID::prepare(struct alter_space *alter)<br> }<br> <br> void<br>-CreateConstraintID::alter(struct alter_space *alter)<br>+CreateConstraintID::alter(struct alter_space *alter) noexcept<br> {<br> /* Alter() can't fail, so can't just throw an error. */<br> if (space_add_constraint_id(alter->old_space, new_id) != 0)<br>@@ -1858,14 +1856,15 @@ CreateConstraintID::alter(struct alter_space *alter)<br> }<br> <br> void<br>-CreateConstraintID::rollback(struct alter_space *alter)<br>+CreateConstraintID::rollback(struct alter_space *alter) noexcept<br> {<br> space_delete_constraint_id(alter->new_space, new_id->name);<br> new_id = NULL;<br> }<br> <br> void<br>-CreateConstraintID::commit(struct alter_space *alter, int64_t signature)<br>+CreateConstraintID::commit(struct alter_space *alter,</div></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="cl_542798"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div>+ int64_t signature) noexcept</div></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div><ol start="4"><li>Here on a new line.</li></ol><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="cl_542798"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div> {<br> (void) alter;<br> (void) signature;<br>@@ -1876,7 +1875,7 @@ CreateConstraintID::commit(struct alter_space *alter, int64_t signature)<br> new_id = NULL;<br> }<br> <br>-CreateConstraintID::~CreateConstraintID()<br>+CreateConstraintID::~CreateConstraintID() noexcept<br> {<br> if (new_id != NULL)<br> constraint_id_delete(new_id);<br>@@ -1891,19 +1890,20 @@ public:<br> DropConstraintID(struct alter_space *alter, const char *name)<br> :AlterSpaceOp(alter), old_id(NULL), name(name)<br> {}<br>- virtual void alter(struct alter_space *alter);<br>- virtual void commit(struct alter_space *alter , int64_t signature);<br>- virtual void rollback(struct alter_space *alter);<br>+ void alter(struct alter_space *alter) noexcept override;<br>+ void commit(struct alter_space *alter,<br>+ int64_t signature) noexcept override;</div></div></div></div></blockquote></div></div></div></div></div></div></blockquote></div><ol start="4"><li>Here on a new line.</li></ol><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="cl_542798"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div><div>+ void rollback(struct alter_space *alter) noexcept override;<br> };<br> <br> void<br>-DropConstraintID::alter(struct alter_space *alter)<br>+DropConstraintID::alter(struct alter_space *alter) noexcept<br> {<br> old_id = space_pop_constraint_id(alter->old_space, name);<br> }<br> <br> void<br>-DropConstraintID::commit(struct alter_space *alter, int64_t signature)<br>+DropConstraintID::commit(struct alter_space *alter, int64_t signature) noexcept<br> {<br> (void) alter;<br> (void) signature;<br>@@ -1911,7 +1911,7 @@ DropConstraintID::commit(struct alter_space *alter, int64_t signature)<br> }<br> <br> void<br>-DropConstraintID::rollback(struct alter_space *alter)<br>+DropConstraintID::rollback(struct alter_space *alter) noexcept<br> {<br> if (space_add_constraint_id(alter->new_space, old_id) != 0) {<br> panic("Can't recover after constraint drop rollback (out of "<br>--<br>2.7.4<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Ilya Kosarev</div></div></div><div> </div></div></div></div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Ilya Kosarev</div></div></div><div> </div></div></BODY></HTML>