<div dir="ltr"><div>Hi!</div><div><br></div><div>Thank you for the patchset, and thank Oleg for the detailed review!</div><div>Whole patch set LGTM.<br></div><div><br></div><div><div><div dir="ltr" data-smartmail="gmail_signature"><div dir="ltr"><span><div><div dir="ltr">Best regards</div><div>Yaroslav Dynnikov<br></div></div></span></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 2 Jul 2020 at 12:50, Cyrill Gorcunov <<a href="mailto:gorcunov@gmail.com" target="_blank">gorcunov@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">For some reason we've disabled usage of json formatter in early<br>
logging since the commit 098324556. Lets allow it back.<br>
<br>
v2:<br>
- add early verification of options for cases like<br>
box.cfg{log="syslog:", log_format="json"}<br>
- extend test<br>
<br>
v3:<br>
- pass the whole cfg table into verify_option helper<br>
- use string.startswith helper in verify_format<br>
<br>
branch gorcunov/gh-5121-logger-boot-json-3<br>
issue <a href="https://github.com/tarantool/tarantool/issues/5121" rel="noreferrer" target="_blank">https://github.com/tarantool/tarantool/issues/5121</a><br>
<br>
Cyrill Gorcunov (3):<br>
core/say: allow to use json in boot logger<br>
lua/log: allow to use json formatter early<br>
test: app-tap/logger -- test json in boottime logger<br>
<br>
src/box/lua/load_cfg.lua | 6 +++---<br>
src/lib/core/say.c | 7 ++----<br>
src/lua/log.lua | 42 +++++++++++++++++++++++++++---------<br>
test/app-tap/logger.test.lua | 19 ++++++++++++----<br>
4 files changed, 52 insertions(+), 22 deletions(-)<br>
<br>
-- <br>
2.26.2<br>
<br>
</blockquote></div>