<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Igor!</p>
<p>I have rebased to master:</p>
<p><a
href="https://gitlab.com/tarantool/tarantool/pipelines/150002628">https://gitlab.com/tarantool/tarantool/pipelines/150002628</a></p>
<p>Unfortunately, release_asan_clang8 fails, however it is not only
my problem.</p>
<p>Moreover, fails not buid but a test.</p>
<p>@ChangeLog</p>
<p>-flag -DENABLE_LTO=ON is passed to luajit<br>
</p>
<h4 class="my-0 mr-2 text-break-word" style="box-sizing: border-box;
margin-top: 0px !important; margin-bottom: 0px !important;
font-weight: 600; line-height: 1.2; color: rgb(46, 46, 46);
font-size: 1.3125rem; margin-right: 0.5rem !important; word-break:
break-all; font-family: -apple-system, system-ui, "Segoe
UI", Roboto, "Noto Sans", Ubuntu, Cantarell,
"Helvetica Neue", sans-serif, "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
letter-spacing: normal; orphans: 2; text-align: left; text-indent:
0px; text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(250, 250, 250); text-decoration-style:
initial; text-decoration-color: initial;"><br>
</h4>
<div class="moz-cite-prefix">26.05.2020 13:11, Igor Munkin пишет:<br>
</div>
<blockquote type="cite"
cite="mid:20200526101108.GL5455@tarantool.org">
<pre class="moz-quote-pre" wrap="">Olya,
Thanks, the patch is nice! I also checked it manually on my Gentoo host
the way Sergey and you proposed:
| $ cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_LTO=ON . &> cmake.out
| $ grep -F 'LTO' cmake.out
| -- Enabling LTO: TRUE
| Setting LTO flags for building luajit
| $ make VERBOSE=1 &> make.out
| $ grep -F 'lj_vm.o' make.out
| ASM lj_vm.o
| /usr/bin/cc -O0 -Wall -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DNVALGRIND=1
| -DLUA_USE_APICHECK=1 -DLUA_USE_ASSERT=1 -DLUAJIT_ENABLE_PAIRSMM=1
| -DLUAJIT_SMART_STRINGS=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
| -U_FORTIFY_SOURCE -fno-stack-protector -fexceptions -funwind-tables
| -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2
| -Wno-parentheses-equality -Wno-tautological-compare
| -Wno-misleading-indentation -Wno-varargs -Wno-implicit-fallthrough -flto
| -fuse-linker-plugin -fno-fat-lto-objects -c -o lj_vm.o lj_vm.S
| gcc-ar rcus libluajit.a lj_vm.o lj_gc.o lj_err.o lj_char.o lj_bc.o
| lj_obj.o lj_buf.o lj_str.o lj_tab.o lj_func.o lj_udata.o lj_meta.o
| lj_debug.o lj_state.o lj_dispatch.o lj_vmevent.o lj_vmmath.o lj_strscan.o
| lj_strfmt.o lj_strfmt_num.o lj_api.o lj_profile.o lj_lex.o lj_parse.o
| lj_bcread.o lj_bcwrite.o lj_load.o lj_ir.o lj_opt_mem.o lj_opt_fold.o
| lj_opt_narrow.o lj_opt_dce.o lj_opt_loop.o lj_opt_split.o lj_opt_sink.o
| lj_mcode.o lj_snap.o lj_record.o lj_crecord.o lj_ffrecord.o lj_asm.o
| lj_trace.o lj_gdbjit.o lj_ctype.o lj_cdata.o lj_cconv.o lj_ccall.o
| lj_ccallback.o lj_carith.o lj_clib.o lj_cparse.o lj_lib.o lj_alloc.o
| lib_aux.o lib_base.o lib_math.o lib_bit.o lib_string.o lib_table.o
| lib_io.o lib_os.o lib_package.o lib_debug.o lib_jit.o lib_ffi.o lib_init.o
I see all requested build options are set. However, I see build failures
on OSX[1] not directly related to the changes. So I propose to rebase
your patch on the current master and re-run full CI pipeline to make
sure there are no build failures related to your patch (but I don't
expect any).
Please also provide a ChangeLog entry.
Otherwise, the changes LGTM, thanks!
Sasha, please proceed with the patch.
<snipped>
[1]: <a class="moz-txt-link-freetext" href="https://gitlab.com/tarantool/tarantool/-/jobs/567445297">https://gitlab.com/tarantool/tarantool/-/jobs/567445297</a>
</pre>
</blockquote>
</body>
</html>