<HTML><BODY><div><div>Sergey,</div><div> </div><div>Thanks for the review.</div><div>I comented your suggestion below and applied changes into branch</div><div><a href="https://github.com/tarantool/tarantool/tree/opiskunov/gh-4856-integration-test-connectors" target="_blank">https://github.com/tarantool/tarantool/tree/opiskunov/gh-4856-integration-test-connectors</a></div><div>I don’t send new patch cause, as we agreed, need to use test-run for testing connectors. </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 21 мая 2020, 19:10 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15900774311331418873_BODY">Hi, Oleg<br><br>Thanks for the patch! See my coments inline.<br><br>> # Release<br>> <br>> build_debian:<br>> - cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}<br>> + cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}<br><br>Why do we need ENABLE_WERROR here?</div></div></div></div></blockquote></div><div>I didn’t add ENABLE_WERROR here — it comes from release build. I have added DENABLE_DIST=ON, and we already discussed it in «vshard» thread.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> +# Integration testing<br>> +<br>> +test_connector_python_asynctnt: build_debian<br>> + make install<br><br>Let's create a separate target for tarantool installation and add it to<br>dependence. Same for targets below.</div></div></div></div></blockquote></div><div>Sure. will do.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>The same question as for vshard - why should we test tarantool against<br>unreleased versions of connectors?</div></div></div></div></blockquote></div><div>I have changed connectors version to the latest released:</div><div> </div><div> java (<a href="https://github.com/tarantool/tarantool-java">https://github.com/tarantool/tarantool-java</a>) — tag: connector-1.9.4<br> python (<a href="https://github.com/tarantool/tarantool-python">https://github.com/tarantool/tarantool-python</a>) — tag: 0.6.6<br> python (<a href="https://github.com/igorcoding/asynctnt">https://github.com/igorcoding/asynctnt</a>) — tag: v1.2<br> golang (<a href="https://github.com/tarantool/go-tarantool">https://github.com/tarantool/go-tarantool</a>) — tag: v1.5<br> golang (<a href="https://github.com/viciious/go-tarantool">https://github.com/viciious/go-tarantool</a>) — tag: v1.0<br> php (<a href="https://github.com/tarantool/tarantool-php">https://github.com/tarantool/tarantool-php</a>) — branch: php7-v2</div><div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></BODY></HTML>