<HTML><BODY><div>Sergey, thanks for review. See my four comments below:<br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 20 мая 2020, 11:07 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:<div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15899620760274488926_BODY">> - test<br>> + - integr_test<br><br>1. We have no string length limitation here, please replace it with<br>"integration_testing".</div></div></div></div></blockquote></div><div>Sure. will do.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br><snipped><br><br>> build_debian:<br>> - cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}<br>> + cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}<br><br>2. What is purpose of enabling ENABLE_DIST here?</div></div></div></div></blockquote></div><div>The reason is that tarantoolctl needed for testing vshard module.<br>-DENABLE_DIST=ON option is used to enable tarantoolctl during «make install».</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> + make install<br>> + git clone --recurse-submodules <a href="https://github.com/tarantool/vshard.git" target="_blank">https://github.com/tarantool/vshard.git</a> vshard<br><br>3. We don't need full GIT history here, so I propose to limit it for 1<br>level with '--depth=1'. It reduces time a bit on clone repository.</div></div></div></div></blockquote></div><div>It doesn’t work, because some tests use git history:</div><div>TEST: reload_evolution/storage.test.lua</div><div>...<br> vshard_copy_path = util.git_checkout('vshard_git_tree_copy', \<br> last_compatible_commit)</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br>4. You are using latest version of vshard from a master branch, so you<br>are testing latest version of tarantool against latest *non-released*<br>version of vshard. Why? From my point of view we should test against<br>released and supported versions of vshard. Latest release was on Feb 24<br>and we must use it in testing.</div></div></div></div></blockquote></div><div>As we discussed in chat — latest version of vshard will be used.</div><div><div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div><style type="text/css"></style></BODY></HTML>