<HTML><BODY><div><br>Sasha, thanks for review. Below my comments.<br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">> +test_module_vshard:<br>> + cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}<br>> + make -j<br><br>Here is the Tarantool building and there is already special rule exists<br>for it, let's use it, like:<br><br>test_module_vshard: build_debian</blockquote></div><div>The reason is that tarantoolctl needed for testing vshard module.</div><div>I’ll reuse «build_debian», but will add -DENABLE_DIST=ON option to it for enable</div><div>tarantoolctl during «make install».</div><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">> + make install<br>> + git clone <a href="https://github.com/tarantool/vshard.git" target="_blank">https://github.com/tarantool/vshard.git</a> tarantool/vshard<br><br>A little bit confising here, if you want additional directory like<br>'tarantool' may be it's better to change it to some name like 'module'.</blockquote></div><div>Sure, will change path to just «vshard»</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">> + cd tarantool/vshard && git submodule update --init --recursive \<br>> + && cmake . && make test<br><br>Seems extra 'submodule update' call to git can be merged to its 'clone'<br>call, like:<br><br>git clone --recurse-submodules <a href="https://...">https://...</a></blockquote></div><div>Sure. Will do.</div><div> </div><div> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></BODY></HTML>