<HTML><BODY><div>LGTM<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 6 мая 2020, 13:23 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15887605891332922755_BODY">From: "Alexander.V Tikhonov" <<a href="/compose?To=avtikhon@tarantool.org">avtikhon@tarantool.org</a>><br><br>Found that modules may have only sources packages w/o binaries<br>packages. Script updated to be able to work with only binaries<br>either sources RPM packages. The same fix was already done for<br>DEB packages at commit 4527a4da9640a63601d0a1d0b2bee7f8cb4c0c85.<br><br>Part of #4839<br>---<br><br>Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/gh-4839-s3-script-full-ci" target="_blank">https://github.com/tarantool/tarantool/tree/avtikhon/gh-4839-s3-script-full-ci</a><br>Issue: <a href="https://github.com/tarantool/tarantool/issues/4839" target="_blank">https://github.com/tarantool/tarantool/issues/4839</a><br><br> tools/update_repo.sh | 17 ++++++++++-------<br> 1 file changed, 10 insertions(+), 7 deletions(-)<br><br>diff --git a/tools/update_repo.sh b/tools/update_repo.sh<br>index 239f74a73..47eadd189 100755<br>--- a/tools/update_repo.sh<br>+++ b/tools/update_repo.sh<br>@@ -617,11 +617,8 @@ function pack_rpm {<br> pack_patterns=$2<br> <br> pack_rpms=$(cd $repo && ls $pack_patterns 2>/dev/null || true)<br>- if [ -z "$pack_rpms" ]; then<br>- echo "ERROR: Current '$repo' path doesn't have '$pack_patterns' packages in path"<br>- usage<br>- exit 1<br>- fi<br>+ [ -n "$pack_rpms" ] || return 0<br>+ packed_rpms=pack_rpms<br> <br> # copy the needed package binaries to the workspace<br> ( cd $repo && cp $pack_rpms $ws/. )<br>@@ -952,7 +949,7 @@ elif [ "$os" == "el" -o "$os" == "fedora" ]; then<br> fi<br> # unlock the publishing<br> $rm_file $ws_lockfile<br>- popd<br>+ popd 2>/dev/null || true<br> <br> # prepare the workspace<br> prepare_ws ${os}_${option_dist}<br>@@ -963,7 +960,13 @@ elif [ "$os" == "el" -o "$os" == "fedora" ]; then<br> fi<br> # unlock the publishing<br> $rm_file $ws_lockfile<br>- popd<br>+ popd 2>/dev/null || true<br>+<br>+ if [ -z "$packed_rpms" ]; then<br>+ echo "ERROR: Current '$repo' path doesn't have '*.x86_64.rpm *.noarch.rpm *.src.rpm' packages in path"<br>+ usage<br>+ exit 1<br>+ fi<br> else<br> echo "USAGE: given OS '$os' is not supported, use any single from the list: $alloss"<br> usage<br>--<br>2.17.1<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></BODY></HTML>