<HTML><BODY><div><div>Alexander, thanks a lot for review!</div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 6 мая 2020, 12:08 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15887560960586379354_BODY">> Keep perf results as gitlab-ci artifacts<br><br>Nit: Let's add some prefix: I would use 'gitlab-ci'. Using of prefixes<br>is convenient and allows to traverse over commits faster.</div></div></div></div></blockquote></div><div>ok.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>><br>> Gitlab-ci pipeline modified in order to keep performance results into gitlab-ci artifacts.<br><br>Nit: Keep commit message body lines within 72 symbols.</div></div></div></div></blockquote></div><div>ok.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> <br>> Closes #4920<br>> <br>> Github: <a href="https://github.com/tarantool/tarantool/tree/opiskunov/gh-4920-perf-artifacts" target="_blank">https://github.com/tarantool/tarantool/tree/opiskunov/gh-4920-perf-artifacts</a><br>> Issue: <a href="https://github.com/tarantool/tarantool/issues/4920" target="_blank">https://github.com/tarantool/tarantool/issues/4920</a><br><br>Nit: Don't include issue no / branch into a commit message, only within<br>a email. Place them under '---' to distinguish from a commit message<br>itself.</div></div></div></div></blockquote></div><div>ok</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> ---<br>> .gitlab-ci.yml | 43 +++++++++++++++++++++++++++++++++++++++++++<br>> 1 file changed, 43 insertions(+)<br>> <br>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml<br>> index fd265aa..4b05fa5 100644<br>> --- a/.gitlab-ci.yml<br>> +++ b/.gitlab-ci.yml<br>> @@ -201,12 +201,22 @@ perf_sysbench:<br>> variables:<br>> <<: *perf_vars_definition<br>> BENCH: 'sysbench'<br>> + artifacts:<br>> + when: always<br>> + paths:<br>> + - Sysbench_result.txt<br>> + - Sysbench_t_version.txt<br><br>I would deploy a directory with result as an artefact or use globs<br>(GitLab CI supports both). gitlab-ci.yml should not lean on hardcoded<br>bench-run paths. Can we formalize bench-run contract for performance<br>measurement results? Maybe, `${benchmark}_results` directory? Or<br>`${benchmark}_${conf}_results` if names intersection may be troublesome.</div></div></div></div></blockquote></div><div>I will use wildcards for this.</div><div> </div><div> <div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></BODY></HTML>