<HTML><BODY><div><div>FWIW — we may commit this patch, but it was failing CI testing some time ago <a href="https://gitlab.com/tarantool/tarantool/pipelines/137481384">https://gitlab.com/tarantool/tarantool/pipelines/137481384</a> Do we have a procedure for rerunning it somehow easily?</div><div> </div><div>Timur <br> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Суббота, 18 апреля 2020, 2:48 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15871673250455317187_BODY">The patchset makes Tarantool stop hiding not explicitly exported<br>symbols.<br><br>It means, all FFI and public C API related symbols are still<br>always exported. All the other symbols may be exported, or may be<br>not.<br><br>That feature was requested solely by Mons.<br><br>To make the needed symbols visible the hack with function<br>addresses was returned back, like it was before<br><a href="https://github.com/tarantool/tarantool/commit/4c4c1ccbe422e1420ce0c0b36194fc61bb857ed4" target="_blank">https://github.com/tarantool/tarantool/commit/4c4c1ccbe422e1420ce0c0b36194fc61bb857ed4</a>,<br>but with 0 dependencies in the export file.<br><br>Branch: <a href="http://github.com/tarantool/tarantool/tree/gerold103/gh-2971-symbols-v2" target="_blank">http://github.com/tarantool/tarantool/tree/gerold103/gh-2971-symbols-v2</a><br>Issue: <a href="https://github.com/tarantool/tarantool/issues/2971" target="_blank">https://github.com/tarantool/tarantool/issues/2971</a><br><br>@ChangeLog<br>- Symbols of tarantool executable are not masked anymore. Some<br> private symbols may become visible and available for FFI and<br> dlopen() + dlsym() (gh-2971).<br><br>Changes in v2:<br>- All exports are moved to one file for simplicity.<br><br>Vladislav Shpilevoy (2):<br> cmake: remove double usage of some source files<br> cmake: remove dynamic-list linker option<br><br> .gitignore | 1 -<br> extra/exports | 404 ----------------<br> src/CMakeLists.txt | 57 +--<br> src/box/CMakeLists.txt | 7 +-<br> src/exports.c | 511 ++++++++++++++++++++<br> src/lib/small | 2 +-<br> src/main.cc | 5 +<br> test/box/gh-2971-symbol-visibility.result | 22 +<br> test/box/gh-2971-symbol-visibility.test.lua | 14 +<br> 9 files changed, 563 insertions(+), 460 deletions(-)<br> delete mode 100644 extra/exports<br> create mode 100644 src/exports.c<br> create mode 100644 test/box/gh-2971-symbol-visibility.result<br> create mode 100644 test/box/gh-2971-symbol-visibility.test.lua<br><br>--<br>2.21.1 (Apple Git-122.3)<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Timur Safin</div></div></div><div> </div></div></BODY></HTML>