<HTML><BODY><div><br>LGTM.<br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Пятница, 13 марта 2020, 11:51 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15840894770696204312_BODY">Changed number of tests to packaging testing jobs from<br>suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",<br>to all suites except 'replication/' suite which has special<br>issue for it's enabling:<br>  <a href="https://github.com/tarantool/tarantool/issues/4798" target="_blank">https://github.com/tarantool/tarantool/issues/4798</a><br>Also added testing to the all available packing jobs except<br>'CentOS 6'.<br><br>Removed test-run option that run testing inline to be<br>able to run it in parallel. Also changed 'test-run' to<br>'make test-force' command.<br><br>After issues #1227 and #1322 the tests were returned<br>into the testing.<br><br>Closes #4599<br>---<br><br>Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/gh-4599-packages-testing-full-ci" target="_blank">https://github.com/tarantool/tarantool/tree/avtikhon/gh-4599-packages-testing-full-ci</a><br>Issue: <a href="https://github.com/tarantool/tarantool/issues/4599" target="_blank">https://github.com/tarantool/tarantool/issues/4599</a><br><br> rpm/tarantool.spec | 32 ++++++++++++++++++++------------<br> 1 file changed, 20 insertions(+), 12 deletions(-)<br><br>diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec<br>index ff95ed646..88b1d6b5c 100644<br>--- a/rpm/tarantool.spec<br>+++ b/rpm/tarantool.spec<br>@@ -69,18 +69,21 @@ BuildRequires: libunwind-devel<br> %undefine _hardened_build<br> %endif<br> <br>-# For tests<br>-%if (0%{?fedora} >= 22 || 0%{?rhel} == 7)<br>-BuildRequires: python >= 2.7<br>-BuildRequires: python-six >= 1.9.0<br>-BuildRequires: python-gevent >= 1.0<br>-BuildRequires: python-yaml >= 3.0.9<br>-%endif<br>+# Set dependences for tests.<br>+# Do not install unused Python 3 packages which<br>+# is default since Fedora 31 and CentOS 8.<br> %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8)<br> BuildRequires: python2 >= 2.7<br> BuildRequires: python2-six >= 1.9.0<br> BuildRequires: python2-gevent >= 1.0<br> BuildRequires: python2-yaml >= 3.0.9<br>+%else<br>+%if (0%{?rhel} != 6)<br>+BuildRequires: python >= 2.7<br>+BuildRequires: python-six >= 1.9.0<br>+BuildRequires: python-gevent >= 1.0<br>+BuildRequires: python-yaml >= 3.0.9<br>+%endif<br> %endif<br> <br> Name: tarantool<br>@@ -160,14 +163,19 @@ make %{?_smp_mflags}<br> rm -rf %{buildroot}%{_datarootdir}/doc/tarantool/<br> <br> %check<br>+%if "%{_ci}" == "travis"<br> %if (0%{?fedora} >= 22 || 0%{?rhel} >= 7)<br>-# <a href="https://github.com/tarantool/tarantool/issues/1227" target="_blank">https://github.com/tarantool/tarantool/issues/1227</a><br>-echo "self.skip = True" > ./test/app/socket.skipcond<br>-# <a href="https://github.com/tarantool/tarantool/issues/1322" target="_blank">https://github.com/tarantool/tarantool/issues/1322</a><br>-echo "self.skip = True" > ./test/app/digest.skipcond<br>-# run a safe subset of the test suite<br> cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/<br> %endif<br>+%else<br>+%if 0%{?rhel} != 6<br>+# Run all available test suites except 'replication'<br>+# which is not currently ready for this testing and<br>+# has standalone issue for it's enabling:<br>+# <a href="https://github.com/tarantool/tarantool/issues/4798" target="_blank">https://github.com/tarantool/tarantool/issues/4798</a><br>+TEST_RUN_EXCLUDE='replication/' make test-force<br>+%endif<br>+%endif<br> <br> %pre<br> /usr/sbin/groupadd -r tarantool > /dev/null 2>&1 || :<br>--<br>2.17.1<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></BODY></HTML>