<HTML><BODY><div>Hi Oleg, thanks for the review, mistakenly missed to remove the middle changes for the future release — corrected and patch resent.<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 15 апреля 2020, 16:24 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15869570960635370585_BODY"><div class="class_1586989922"><div><div>Hi,<br> <br>Sasha, thanks for the patch. </div><div> </div><div>As I can see you are not only remove ubuntu_19_04 and ubuntu_19_04_deploy, but</div><div>also adding ubuntu_20_04_deploy. Which is not related to commit message and issue. </div><div> </div><div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><span data-email="avtikhon@tarantool.org" data-name="Alexander V. Tikhonov" data-quote-id="1703982426673891310" data-timestamp="1586930820" data-type="sender">Среда, 15 апреля 2020, 9:07 +03:00 от Alexander V. Tikhonov <<a href="/compose?To=avtikhon@tarantool.org">avtikhon@tarantool.org</a>>:<br> </span><div data-quote-id="1703982426673891310" data-type="body"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><style type="text/css"></style><div><div id="style_15869308540073513592_BODY_mailru_css_attribute_postfix">Removed Ubuntu 19.04 Disco from testing which is EOL.<br><br>Close #4896<br>---<br><br>Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci" rel="noopener noreferrer" target="_blank">https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci</a><br>Issue: <a href="https://github.com/tarantool/tarantool/issues/4896" rel="noopener noreferrer" target="_blank">https://github.com/tarantool/tarantool/issues/4896</a><br><br> .gitlab-ci.yml | 14 ++++----------<br> .travis.yml | 3 ---<br> 2 files changed, 4 insertions(+), 13 deletions(-)<br><br>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml<br>index cd710027f..9c996fd7b 100644<br>--- a/.gitlab-ci.yml<br>+++ b/.gitlab-ci.yml<br>@@ -323,12 +323,6 @@ ubuntu_18_04:<br> OS: 'ubuntu'<br> DIST: 'bionic'<br> <br>-ubuntu_19_04:<br>- <<: *pack_definition<br>- variables:<br>- OS: 'ubuntu'<br>- DIST: 'disco'<br>-<br> ubuntu_19_10:<br> <<: *pack_definition<br> variables:<br>@@ -415,17 +409,17 @@ ubuntu_18_04_deploy:<br> OS: 'ubuntu'<br> DIST: 'bionic'<br> <br>-ubuntu_19_04_deploy:<br>+ubuntu_19_10_deploy:<br> <<: *deploy_definition<br> variables:<br> OS: 'ubuntu'<br>- DIST: 'disco'<br>+ DIST: 'eoan'<br> <br>-ubuntu_19_10_deploy:<br>+ubuntu_20_04_deploy:<br> <<: *deploy_definition<br> variables:<br> OS: 'ubuntu'<br>- DIST: 'eoan'<br>+ DIST: 'focal'<br> <br> debian_8_deploy:<br> <<: *deploy_definition<br>diff --git a/.travis.yml b/.travis.yml<br>index c63ab3ebd..41540fb79 100644<br>--- a/.travis.yml<br>+++ b/.travis.yml<br>@@ -67,9 +67,6 @@ jobs:<br> - name: "Ubuntu Bionic (18.04) build + deploy DEB"<br> env: OS=ubuntu DIST=bionic<br> if: branch = "master"<br>- - name: "Ubuntu Disco (19.04) build + deploy DEB"<br>- env: OS=ubuntu DIST=disco<br>- if: branch = "master"<br> - name: "Ubuntu Eoan (19.10) build + deploy DEB"<br> env: OS=ubuntu DIST=eoan<br> if: branch = "master"<br>--<br>2.17.1<br> </div></div></div></div></div></blockquote></div> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></div></div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>