<HTML><BODY><div>Hi Sergey, thanks for the patch, LGTM.<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Вторник, 14 апреля 2020, 12:55 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15868581101713845013_BODY">By default lcov collects line coverage only. It would be useful to<br>collect function and branch coverage too.<br><br>Closes #4888<br>---<br><br>GH branch: <a href="https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage" target="_blank">https://github.com/tarantool/tarantool/tree/ligurio/gh-4888-branch-coverage</a><br>GH issue: <a href="https://github.com/tarantool/tarantool/issues/4891" target="_blank">https://github.com/tarantool/tarantool/issues/4891</a><br>Example on Coveralls (column "Run details"): <a href="https://coveralls.io/builds/30058630" target="_blank">https://coveralls.io/builds/30058630</a><br><br> .travis.mk | 5 +++--<br> 1 file changed, 3 insertions(+), 2 deletions(-)<br><br>diff --git a/.travis.mk b/.travis.mk<br>index f709a18b6..a92efbcd6 100644<br>--- a/.travis.mk<br>+++ b/.travis.mk<br>@@ -96,9 +96,10 @@ build_coverage_debian:<br> test_coverage_debian_no_deps: build_coverage_debian<br> # Enable --long tests for coverage<br> cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS) --long<br>- lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp<br>+ lcov --compat-libtool --directory src/ --capture --output-file coverage.info.tmp \<br>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1<br> lcov --compat-libtool --remove coverage.info.tmp 'tests/*' 'third_party/*' '/usr/*' \<br>- --output-file coverage.info<br>+ --rc lcov_branch_coverage=1 --rc lcov_function_coverage=1 --output-file coverage.info<br> lcov --list coverage.info<br> @if [ -n "$(COVERALLS_TOKEN)" ]; then \<br> echo "Exporting code coverage information to coveralls.io"; \<br>--<br>2.23.0<br><br><br>--<br>sergeyb@</div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>