<HTML><BODY><div>Hi Oleg, thanks for the review, as I see the only question why we may need this patch as a temporary solution. The purpose of this patch is to save the stability of the testing code on OSX version, while this is the only way to test it. It can be used in the standalone branch as it is, without pushing to mainline.<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 13 апреля 2020, 13:50 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15867750471210363423_BODY"><div class="class_1586795600"><div><div>Hi,</div><div> </div><div>Sasha, thanks for the patch. See my comment below.<br> </div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;">Четверг, 9 апреля 2020, 11:41 +03:00 от Alexander V. Tikhonov <<a href="/compose?To=avtikhon@tarantool.org">avtikhon@tarantool.org</a>>:<br> <div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><style type="text/css"></style><div><div id="style_15864216621283348806_BODY_mailru_css_attribute_postfix">Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,<br>due to decided to have only 2 last major releases, for now it is<br>10.14 and 10.15 OSX versions. Also changed the commit job for branches<br>from 10.14 to 10.15 OSX version.</div></div></div></div></blockquote></div><div>As far as I remember we agreed to use new HW mac mini for testing 10.15 OSX version.</div><div>I don’t understand why you trying to use VMS for it.</div><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div><br>Added to OSX 10.15 additional call to /etc/profile to setup the PATH,<br>otherwise it doesn't have the path to brew installed packages.<br>---<br> .gitlab-ci.yml | 11 ++++++-----<br> 1 file changed, 6 insertions(+), 5 deletions(-)<br><br>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml<br>index cd710027f..5c9f353a7 100644<br>--- a/.gitlab-ci.yml<br>+++ b/.gitlab-ci.yml<br>@@ -139,19 +139,20 @@ release_asan_clang8:<br> script:<br> - ${GITLAB_MAKE} test_asan_debian_no_deps<br> <br>-osx_13_release:<br>- <<: *release_only_definition<br>+osx_15_release:<br> <<: *vbox_definition<br> tags:<br>- - vms_osx_13<br>+ - vms_osx_15<br> variables:<br>- VMS_NAME: 'osx_13'<br>+ EXTRA_ENV: '. /etc/profile ;'<br>+ VMS_NAME: 'osx_15'<br> VMS_USER: 'tarantool'<br>- VMS_PORT: '2212'<br>+ VMS_PORT: '2242'<br> script:<br> - ${GITLAB_MAKE} vms_test_osx<br> <br> osx_14_release:<br>+ <<: *release_only_definition<br> <<: *docker_test_definition<br> tags:<br> - osx_14<br>--<br>2.17.1<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></div></div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>