<HTML><BODY><div>Hi, Oleg, thanks for the review, please check my comments below.<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 13 апреля 2020, 13:57 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15867754611726510949_BODY"><div class="class_1586794246"><div>Hi,<br> <br>Sasha, thanks for the patch. See my comment below.<br> <blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;">Четверг, 9 апреля 2020, 11:41 +03:00 от Alexander V. Tikhonov <<a href="/compose?To=avtikhon@tarantool.org">avtikhon@tarantool.org</a>>:<br> <div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><style type="text/css"></style><div><div id="style_15864216620285567922_BODY_mailru_css_attribute_postfix">Formula tntpython2.rb consist of the packages which download target host<br>does not have valid SSL certificate, disabled curl SSL check for it.<br>---<br> .travis.mk | 15 +++++++++++++--<br> 1 file changed, 13 insertions(+), 2 deletions(-)<br><br>diff --git a/.travis.mk b/.travis.mk<br>index f709a18b6..e79d50b19 100644<br>--- a/.travis.mk<br>+++ b/.travis.mk<br>@@ -151,7 +151,7 @@ test_static_docker_build:<br> <br> # since Python 2 is EOL it's latest commit from tapped local formula is used<br> OSX_PKGS=openssl readline curl icu4c libiconv zlib autoconf automake libtool \<br>- cmake file://${PWD}/tools/brew_taps/tntpython2.rb<br>+ cmake</div></div></div></div></blockquote></div><ol><li>As you move formula from this place, please move above comment as well.</li></ol></div></div></div></div></div></blockquote></div><div>Right, I forgot to move it down, corrected.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="class_1586794246"><ol><li>Would be good to have one line in this place:<br>OSX_PKGS=openssl readline curl icu4c libiconv zlib autoconf automake libtool cmake</li></ol></div></div></div></div></div></blockquote></div><div>Unfortunately the string breaks the limit of 80 chars and must be splitted.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="class_1586794246"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div> <br> deps_osx:<br> # install brew using command from Homebrew repository instructions:<br>@@ -164,7 +164,18 @@ deps_osx:<br> # try to install the packages either upgrade it to avoid of fails<br> # if the package already exists with the previous version<br> brew install --force ${OSX_PKGS} || brew upgrade ${OSX_PKGS}<br>- pip install --force-reinstall -r test-run/requirements.txt<br>+ # Formula tntpython2.rb consist of the packages which download target<br>+ # host does not have valid SSL certificate, disabled curl SSL<br>+ # check for it.</div></div></div></div></blockquote></div><div>Above comment really ugly. Please rewrite it more clearly.</div></div></div></div></div></div></blockquote></div><div>Sure, I’ve rewrote it once again.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><div class="class_1586794246"><div><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div>+ echo insecure >>${HOME}/.curlrc<br>+ brew install --force file://${PWD}/tools/brew_taps/tntpython2.rb || true<br>+ sed '$d' ${HOME}/.curlrc >${HOME}/.curlrc.new && \<br>+ mv ${HOME}/.curlrc.new ${HOME}/.curlrc<br>+ python2 -V<br>+ pip install --trusted-host files.pythonhosted.org \<br>+ --upgrade pip setuptools<br>+ pip install --trusted-host files.pythonhosted.org \<br>+ --force-reinstall -r test-run/requirements.txt<br> <br> build_osx:<br> cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}<br>--<br>2.17.1<br> </div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Oleg Piskunov</div></div></div><div> </div></div></div></div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>