<HTML><BODY><div>Alexander, I’ve corrected the patch as you suggested, thank you.<br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 25 марта 2020, 16:38 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15851435170694111510_BODY">> >> >> + brew update || echo | /usr/bin/ruby -e \<br>> >> >> + "$(curl -fsSL <a href="https://raw.githubusercontent.com/Homebrew/install/master/install" target="_blank">https://raw.githubusercontent.com/Homebrew/install/master/install</a> )"<br>> >> ><br>> >> >Why don't update formulae after installing brew?<br>> >><br>> >> The tapped formula does not exist in brew any more, though it can’t be<br>> >> updated.<br>> ><br>> >After installing brew you'll have fresh brew, but no formulae, I guess.<br>> >Will the next `brew install` work? I guess, no. You need `brew update`<br>> >after this.<br>><br>> I’ve tried to remove the brew and reinstalled it with this command,<br>> seems that all needed updates were tried to do during the<br>> installation:<br><br>Okay so.<br><br>> >> >From the previous review [1]:<br>> >> ><br>> >> >> > The problem with 'var' directory is not related to the new way to Python<br>> >> >> > 2 installation? Why everything is in one commit?<br>> >> >><br>> >> >> This commit is about OSX host setup for building and testing, so I<br>> >> >> think it is ok to set it here.<br>> >> ><br>> >> >It sounds as 'because something going not right, when something was<br>> >> >changed'. Neat reason.<br>> >> ><br>> >> >I cannot say neither 'ok', not 'not ok' for this. Okay, I can guess that<br>> >> >working directory is changed somehow, but why and where?<br>> >><br>> >> ‘var’ directory lays too deep at the path and the length of the path<br>> >> is too long for test-run.py tool which fails because of it, the<br>> >> solution to fix it is to use the short link for the ‘var’ directory.<br>> ><br>> >Why it was okay, but becomes too long?<br>> Because the name of the user on the new mac mini and its home path is really long<br>> echo ~ | wc -c<br>> 28<br>> also the path of tarantool/test/var adds.<br><br>Okay, so it worth to state something like:<br><br>> We're going to enable new Mac machines into CI and usernames on them<br>> are long according to internal policies. It makes a home directory to<br>> be long too and so a path to a unix socket created during testing can<br>> be longer then UNIX_PATH_MAX constant (108). Move the working<br>> directory for testing into <...>.<br><br>It would be also good to link the issue, which describes some details<br>around the path length limit:<br><a href="https://github.com/tarantool/tarantool/issues/4634" target="_blank">https://github.com/tarantool/tarantool/issues/4634</a></div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>