

<HTML><BODY><div><br>Igor, thanks for your review, I’ve made all the changes you suggested.<br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Пятница, 28 февраля 2020, 21:42 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15829153561161588725_BODY">Sasha,<br><br>Thanks for the patch. I left some comments below, please consider them.<br><br>On 27.02.20, Alexander V. Tikhonov wrote:<br>> Renamed test files in the following way:<br>> <repo>-<number>-<comment>.test.lua<br>> where "external repo" is github repository:<br><br>Typo: s/external repo/<repo>/.</div></div></div></div></blockquote></div><div>Done.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br>> gh - tarantool/tarantool<br>> lj - luajit/luajit<br><br>Typo: s/luajit/LuaJIT/g.</div></div></div></div></blockquote></div><div>Done.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> or - openresty/lua-resty-core<br><br>Typo: s/lua-resty-core/luajit2/.</div></div></div></div></blockquote></div><div>Done.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>><br>> Close #4655<br>> ---<br>> test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} | 0<br>> ...ording.test.lua => gh-4476-fix-string-find-recording.test.lua} | 0<br>> ...mm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} | 0<br>> ...JIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} | 0<br>> ...LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} | 0<br>> test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} | 0<br>> ...LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} | 0<br>> 7 files changed, 0 insertions(+), 0 deletions(-)<br>> rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (100%)<br>> rename test/{fix_string_find_recording.test.lua => gh-4476-fix-string-find-recording.test.lua} (100%)<br>> rename test/{pairsmm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} (100%)<br>> rename test/{table_chain_bug_LuaJIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} (100%)<br>> rename test/{fold_bug_LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} (100%)<br>> rename test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} (100%)<br>> rename test/{fold_bug_LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} (100%)<br>><br>> diff --git a/test/gh.test.lua b/test/gh-3196-incorrect-string-length.test.lua<br>> similarity index 100%<br>> rename from test/gh.test.lua<br>> rename to test/gh-3196-incorrect-string-length.test.lua<br>> diff --git a/test/fix_string_find_recording.test.lua b/test/gh-4476-fix-string-find-recording.test.lua<br>> similarity index 100%<br>> rename from test/fix_string_find_recording.test.lua<br>> rename to test/gh-4476-fix-string-find-recording.test.lua<br><br>I propose test/gh-4476-fix-string-find-recording.test.lua.</div></div></div></div></blockquote></div><div>Seems the same.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> diff --git a/test/pairsmm_tarantool_4560.test.lua b/test/gh-4560-pairsmm-is-set.test.lua<br>> similarity index 100%<br>> rename from test/pairsmm_tarantool_4560.test.lua<br>> rename to test/gh-4560-pairsmm-is-set.test.lua<br><br>Please rebase your changes on the stable branch, since this test has<br>been removed in a9eebfa.</div></div></div></div></blockquote></div><div>Done - test removed.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> diff --git a/test/table_chain_bug_LuaJIT_494.test.lua b/test/lj-494-table-chain-infinite-loop.test.lua<br>> similarity index 100%<br>> rename from test/table_chain_bug_LuaJIT_494.test.lua<br>> rename to test/lj-494-table-chain-infinite-loop.test.lua<br>> diff --git a/test/fold_bug_LuaJIT_505.test.lua b/test/lj-505-fold-icorrect-behavior.test.lua<br>> similarity index 100%<br>> rename from test/fold_bug_LuaJIT_505.test.lua<br>> rename to test/lj-505-fold-icorrect-behavior.test.lua<br><br>I propose test/lj-505-fold-no-strref-for-ptrdiff.test.lua.</div></div></div></div></blockquote></div><div>Done.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> diff --git a/test/unsink_64_kptr.test.lua b/test/or-232-unsink-64-kptr.test.lua<br>> similarity index 100%<br>> rename from test/unsink_64_kptr.test.lua<br>> rename to test/or-232-unsink-64-kptr.test.lua<br>> diff --git a/test/fold_bug_LuaJIT_524.test.lua b/test/or-524-fold-icorrect-behavior.test.lua<br>> similarity index 100%<br>> rename from test/fold_bug_LuaJIT_524.test.lua<br>> rename to test/or-524-fold-icorrect-behavior.test.lua<br><br>The original issue comes from LuaJIT/LuaJIT queue, so the prefix should<br>be 'lj-' instead of 'or-'. Also there is a typo: s/icorrect/incorrect/.<br><br>I propose test/lj-524-fold-conv-respect-src-irt.test.lua.</div></div></div></div></blockquote></div><div>Done.</div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div>> --<br>> 2.17.1<br>><br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Alexander Tikhonov</div></div></div><div> </div></div></BODY></HTML>