<HTML><BODY>Alexander, thanks for the review, added comment as you suggested.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Четверг, 12 марта 2020, 14:03 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15840110281012719113_BODY">> >> # For tests<br>
> >> -%if (0%{?fedora} >= 22 || 0%{?rhel} == 7)<br>
> >> -BuildRequires: python >= 2.7<br>
> >> -BuildRequires: python-six >= 1.9.0<br>
> >> -BuildRequires: python-gevent >= 1.0<br>
> >> -BuildRequires: python-yaml >= 3.0.9<br>
> >> -%endif<br>
> >> %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8)<br>
> >> BuildRequires: python2 >= 2.7<br>
> >> BuildRequires: python2-six >= 1.9.0<br>
> >> BuildRequires: python2-gevent >= 1.0<br>
> >> BuildRequires: python2-yaml >= 3.0.9<br>
> >> +%else<br>
> >> +%if (0%{?rhel} != 6)<br>
> ><br>
> >Don't understood: what was actually changed? We have Fedora 28-31 and<br>
> >CentOS 6-8 in testing / deploying. <br>
> Please check the next comment.<br>
> ><br>
> ><br>
> >> +BuildRequires: python >= 2.7<br>
> >> +BuildRequires: python-six >= 1.9.0<br>
> >> +BuildRequires: python-gevent >= 1.0<br>
> >> +BuildRequires: python-yaml >= 3.0.9<br>
> >> +%endif<br>
> >> %endif<br>
> >> <br>
> In the current change and one before, the check of the versions added. Before it<br>
> was that only Fedora and CentOS installed the python packages for the testing.<br>
> As after the change all OSs (except CentOS 6) will have it installed except<br>
> Fedora since 31 version and CentOS since 8 version will have python2.<br>
<br>
After I discussed it voicely with Alexander I got what was changed.<br>
<br>
Fedora 31 and CentOS 8 installs both python-foo and python2-foo<br>
dependencies, while python-foo is actually alias for python3-foo. It<br>
does not fail the build, but is not used.<br>
<br>
I'm okay to remove unused Python 3 deps, but let's add a comment here<br>
(right in the spec): it is not obvious, you see.<br>
<br>
> >> %check<br>
> >> -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7)<br>
> >> # <a href="https://github.com/tarantool/tarantool/issues/1227" target="_blank">https://github.com/tarantool/tarantool/issues/1227</a><br>
> >> echo "self.skip = True" > ./test/app/socket.skipcond<br>
> >> # <a href="https://github.com/tarantool/tarantool/issues/1322" target="_blank">https://github.com/tarantool/tarantool/issues/1322</a><br>
> >> echo "self.skip = True" > ./test/app/digest.skipcond<br>
> ><br>
> >Those two issues now closed. Maybe it is time to enable those tests?<br>
> Sure, I'll add separate commit into the current patch set.<br>
<br>
As I see on the branch (avtikhon/gh-4599-packages-testing-full-ci), you<br>
removed it right in this commit. Anyway, it is okay for me.<br>
<br>
> >> -cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/<br>
> >> +%if (0%{?rhel} != 6)<br>
> >> + TEST_RUN_EXCLUDE='replication/' make test-force<br>
> >> %endif<br>
> ><br>
> >Flaky fails rate will increase on Travis-CI if we'll enable<br>
> >parallelization. Either discard this change or enable it only for<br>
> >gitlab-ci. <br>
> Added mark 'IS_TRAVIS' to be changed by packpack on run.<br>
<br>
Commented in <a href="https://github.com/packpack/packpack/pull/116" target="_blank">https://github.com/packpack/packpack/pull/116</a><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>