<HTML><BODY><div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15834152880567918592_BODY"><div class="class_1583858556">
Alexander, thanks for your review, I've made all the changes that you asked.<br><br><br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;">
Пятница, 21 февраля 2020, 14:19 +03:00 от Alexander Turenko <<a href="mailto:alexander.turenko@tarantool.org">alexander.turenko@tarantool.org</a>>:<br><br><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix">I have several questions, see below.<br><br>
WBR, Alexander Turenko.<br><br>
On Mon, Dec 30, 2019 at 02:10:07PM +0300, Alexander V. Tikhonov wrote:<br>
> Changed number of tests to packaging testing jobs from<br>
> suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/",<br>
> to all suites except 'replication/' suite. Also added<br>
> testing to the all available packing jobs except 'CentOS 6'.<br>
> <br>
> Removed test-run option that run testing inline to be<br>
> able to run it in parallel. Also changed 'test-run' to<br>
> 'make test-force' command.<br>
> <br>
> Closes #4599<br>
> ---<br>
> <br>
> Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/gh-4599-packages-testing-full-ci" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/tree/avtikhon/gh-4599-packages-testing-full-ci</a><br>
> Issue: <a href="https://github.com/tarantool/tarantool/issues/4599" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/issues/4599</a><br>
> <br>
> rpm/tarantool.spec | 17 +++++++++--------<br>
> 1 file changed, 9 insertions(+), 8 deletions(-)<br>
> <br>
> diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec<br>
> index ff95ed646..bc1fb5aff 100644<br>
> --- a/rpm/tarantool.spec<br>
> +++ b/rpm/tarantool.spec<br>
> @@ -70,17 +70,18 @@ BuildRequires: libunwind-devel<br>
> %endif<br>
> <br>
> # For tests<br>
> -%if (0%{?fedora} >= 22 || 0%{?rhel} == 7)<br>
> -BuildRequires: python >= 2.7<br>
> -BuildRequires: python-six >= 1.9.0<br>
> -BuildRequires: python-gevent >= 1.0<br>
> -BuildRequires: python-yaml >= 3.0.9<br>
> -%endif<br>
> %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8)<br>
> BuildRequires: python2 >= 2.7<br>
> BuildRequires: python2-six >= 1.9.0<br>
> BuildRequires: python2-gevent >= 1.0<br>
> BuildRequires: python2-yaml >= 3.0.9<br>
> +%else<br>
> +%if (0%{?rhel} != 6)<br><br>
Don't understood: what was actually changed? We have Fedora 28-31 and<br>
CentOS 6-8 in testing / deploying.</div></div></div></div></blockquote>Please check the next comment.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br><br>
> +BuildRequires: python >= 2.7<br>
> +BuildRequires: python-six >= 1.9.0<br>
> +BuildRequires: python-gevent >= 1.0<br>
> +BuildRequires: python-yaml >= 3.0.9<br>
> +%endif<br>
> %endif<br>
> </div></div></div></div></blockquote>In the current change and one before, the check of the versions added. Before it<br>was that only Fedora and CentOS installed the python packages for the testing.<br>As after the change all OSs (except CentOS 6) will have it installed except<br>Fedora since 31 version and CentOS since 8 version will have python2.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br>
> Name: tarantool<br>
> @@ -160,13 +161,13 @@ make %{?_smp_mflags}<br>
> rm -rf %{buildroot}%{_datarootdir}/doc/tarantool/<br>
> <br>
> %check<br>
> -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7)<br>
> # <a href="https://github.com/tarantool/tarantool/issues/1227" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/issues/1227</a><br>
> echo "self.skip = True" > ./test/app/socket.skipcond<br>
> # <a href="https://github.com/tarantool/tarantool/issues/1322" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/issues/1322</a><br>
> echo "self.skip = True" > ./test/app/digest.skipcond<br><br>
Those two issues now closed. Maybe it is time to enable those tests?<br></div></div></div></div></blockquote>Sure, I'll add separate commit into the current patch set.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br>
> # run a safe subset of the test suite<br><br>
I would file an issue re enabling replication test suite and mention it<br>
here: it looks as good process for me. However, up to you.</div></div></div></div></blockquote><p>Sure - added new issue:<br></p><p> <a href="https://github.com/tarantool/tarantool/issues/4798" target="_blank" rel=" noopener noreferrer">https://github.com/tarantool/tarantool/issues/4798</a><br></p><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br><br>
> -cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/<br>
> +%if (0%{?rhel} != 6)<br>
> + TEST_RUN_EXCLUDE='replication/' make test-force<br>
> %endif<br><br>
Flaky fails rate will increase on Travis-CI if we'll enable<br>
parallelization. Either discard this change or enable it only for<br>
gitlab-ci.</div></div></div></div></blockquote>Added mark 'IS_TRAVIS' to be changed by packpack on run.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br><br>
Nit: Use whitespace (not tab) for indentation here.</div></div></div></div></blockquote>Corrected.<br><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px;"><div id=""><div class="js-helper_mailru_css_attribute_postfix js-readmsg-msg_mailru_css_attribute_postfix"><div><div id="style_15822839542129811130_BODY_mailru_css_attribute_postfix"><br></div></div></div></div></blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br>
</div></div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div></BODY></HTML>