<HTML><BODY><div>Both minor comments are fixed. <br><br> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Среда, 26 февраля 2020, 16:56 +03:00 от Igor Munkin <imun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15827253801110978110_BODY">Masha,<br><br>Thanks for the patch! I left some nits below, please consider them.<br>Otherwise, LGTM.<br><br>On 27.01.20, Maria Khaydich wrote:<br>><br>> Thank you for the review! All fixes below<br>> <br>> ----------------------------------------------------------------------<br>> Branch:<br>> <a href="https://github.com/tarantool/tarantool/compare/eljashm/gh-4513-netbox.self-convert-tuples-to-table-type" target="_blank">https://github.com/tarantool/tarantool/compare/eljashm/gh-4513-netbox.self-convert-tuples-to-table-type</a><br>> Issue:<br>> <a href="https://github.com/tarantool/tarantool/issues/4513" target="_blank">https://github.com/tarantool/tarantool/issues/4513</a><br>> <br>> src/box/lua/net_box.lua | 8 +++-<br>> test/app-tap/debug.result | 8 ++--<br>> test/box-tap/net.box.test.lua | 3 +-<br>> test/box/engine.cfg | 6 +++<br>> ...ox-self-and-connect-interchangeable.result | 44 +++++++++++++++++++<br>> ...-self-and-connect-interchangeable.test.lua | 20 +++++++++<br>> test/box/suite.ini | 1 +<br>> 7 files changed, 83 insertions(+), 7 deletions(-)<br>> create mode 100644 test/box/engine.cfg<br>> create mode 100644 test/box/gh-4513-netbox-self-and-connect-interchangeable.result<br>> create mode 100644 test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua<br><br><snipped><br><br>> diff --git a/test/box-tap/net.box.test.lua b/test/box-tap/net.box.test.lua<br>> index a46f28ad0..577e97d78 100755<br>> --- a/test/box-tap/net.box.test.lua<br>> +++ b/test/box-tap/net.box.test.lua<br>> @@ -30,5 +30,4 @@ test:ok(not pcall(function() conn.space._vspace:insert() end), "error handling")<br>> -- cleanup<br>> conn:close()<br>> inspector:cmd('stop server second with cleanup=1')<br>> -test:check()<br>> -os.exit(0)<br>> +os.exit(test:check() and 0 or 1)<br><br>The changes are fine but look like not related to the subj.<br><br>> diff --git a/test/box/engine.cfg b/test/box/engine.cfg<br><br><snipped><br><br>> diff --git a/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua b/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua<br>> new file mode 100644<br>> index 000000000..5e8ae7465<br>> --- /dev/null<br>> +++ b/test/box/gh-4513-netbox-self-and-connect-interchangeable.test.lua<br>> @@ -0,0 +1,20 @@<br>> +netbox = require('net.box')<br>> +test_run = require('test_run').new()<br>> +remote = test_run:get_cfg('remote') == 'true'<br>> +test_run:cmd("setopt delimiter ';'")<br>> +<br>> +nb = nil<br>> +if remote then<br>> + box.schema.user.grant('guest','super')<br>> + nb = netbox.connect(box.cfg.listen)<br>> +else<br>> + nb = netbox.self<br>> +end;<br>> +<br>> +--<br>> +-- netbox:self and netbox:connect should work interchangeably<br>> +--<br>> +test_run:cmd("setopt delimiter ''");<br><br>Minor: The line above relates to the nb initialization, so it's better<br>been placed before the comment. It's totally minor, feel free to ignore.<br><br>> +type(nb:eval('return box.tuple.new{1}')) -- table<br>> +type(nb:eval('return box.error.new(1, "test error")')) -- string<br>> +type(nb:eval('return box.NULL')) -- cdata<br><br><snipped><br><br>> -- <br>> 2.24.0<br><br><snipped><br><br>--<br>Best regards,<br>IM</div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Maria Khaydich</div></div></div><div> </div></div></BODY></HTML>