<HTML><BODY>Igor,<br><br>Thanks for the review, I've changed the commit message as you suggested.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Понедельник, 13 января 2020, 15:07 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15789172450100210493_BODY">Sasha,<br>
<br>
Thanks for the patch!<br>
<br>
IMHO gh prefix can be used for the issues filed in Tarantool queue and<br>
is excess for the tests related to issues from other queues. Otherwise<br>
e.g. tnt prefix can be used for the issues origined to Tarantool and gh<br>
prefix can be dropped at all. The naming you propose within this patch<br>
looks too long for me.<br>
<br>
On 16.12.19, Alexander V. Tikhonov wrote:<br>
> Renamed test files in the following way:<br>
> [gh-[external repo]-<number>-]comment.test.lua<br>
> where "external repo" is github repository:<br>
> lj - luajit/luajit<br>
> lrc - openresty/lua-resty-core<br>
<br>
The openresty queue is located in openresty/luajit2 repo. Furthermore<br>
or (for openresty) feems to be more correct for the corresponding<br>
prefix.<br>
<br>
> <br>
> Close #4655<br>
> ---<br>
> test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} | 0<br>
> ...mm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} | 0<br>
> ...n_bug_LuaJIT_494.test.lua => gh-lj-494-infinite-loop.test.lua} | 0<br>
> ...JIT_505.test.lua => gh-lj-505-fold-icorrect-behavior.test.lua} | 0<br>
> ...JIT_524.test.lua => gh-lj-524-fold-icorrect-behavior.test.lua} | 0<br>
> ...{unsink_64_kptr.test.lua => gh-lrc-64-unsink-64-kptr.test.lua} | 0<br>
> 6 files changed, 0 insertions(+), 0 deletions(-)<br>
> rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (100%)<br>
> rename test/{pairsmm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} (100%)<br>
> rename test/{table_chain_bug_LuaJIT_494.test.lua => gh-lj-494-infinite-loop.test.lua} (100%)<br>
<br>
table-chain-infinite-loop looks more correct.<br>
<br>
> rename test/{fold_bug_LuaJIT_505.test.lua => gh-lj-505-fold-icorrect-behavior.test.lua} (100%)<br>
> rename test/{fold_bug_LuaJIT_524.test.lua => gh-lj-524-fold-icorrect-behavior.test.lua} (100%)<br>
> rename test/{unsink_64_kptr.test.lua => gh-lrc-64-unsink-64-kptr.test.lua} (100%)<br>
> <br>
> diff --git a/test/gh.test.lua b/test/gh-3196-incorrect-string-length.test.lua<br>
> similarity index 100%<br>
> rename from test/gh.test.lua<br>
> rename to test/gh-3196-incorrect-string-length.test.lua<br>
> diff --git a/test/pairsmm_tarantool_4560.test.lua b/test/gh-4560-pairsmm-is-set.test.lua<br>
> similarity index 100%<br>
> rename from test/pairsmm_tarantool_4560.test.lua<br>
> rename to test/gh-4560-pairsmm-is-set.test.lua<br>
> diff --git a/test/table_chain_bug_LuaJIT_494.test.lua b/test/gh-lj-494-infinite-loop.test.lua<br>
> similarity index 100%<br>
> rename from test/table_chain_bug_LuaJIT_494.test.lua<br>
> rename to test/gh-lj-494-infinite-loop.test.lua<br>
> diff --git a/test/fold_bug_LuaJIT_505.test.lua b/test/gh-lj-505-fold-icorrect-behavior.test.lua<br>
> similarity index 100%<br>
> rename from test/fold_bug_LuaJIT_505.test.lua<br>
> rename to test/gh-lj-505-fold-icorrect-behavior.test.lua<br>
> diff --git a/test/fold_bug_LuaJIT_524.test.lua b/test/gh-lj-524-fold-icorrect-behavior.test.lua<br>
> similarity index 100%<br>
> rename from test/fold_bug_LuaJIT_524.test.lua<br>
> rename to test/gh-lj-524-fold-icorrect-behavior.test.lua<br>
> diff --git a/test/unsink_64_kptr.test.lua b/test/gh-lrc-64-unsink-64-kptr.test.lua<br>
> similarity index 100%<br>
> rename from test/unsink_64_kptr.test.lua<br>
> rename to test/gh-lrc-64-unsink-64-kptr.test.lua<br>
<br>
test/fix_string_find_recodring.test.lua is missing.<br>
<br>
> -- <br>
> 2.17.1<br>
> <br>
<br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>