<HTML><BODY>Masha,<br><br>The fix LGTM, because the test that uses some resources should always be sure<br> that it is free. Anyway harness should try to help the tests to avoid of such issues,<br>but it will never reach absolute confidence that all situations are under control, so<br>the test will be ahead of it in preparing such resources. As about harness then it<br>can be improved by the QA for the same issues too. As for now, this fix is completely<br>correct and needed.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 26 февраля 2020, 18:00 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15827292420431032095_BODY">Masha,<br>
<br>
As Sasha Tu. noticed it looks to be related to the test-run issue[1].<br>
<br>
Cced Sasha Ti. to take a look on the changes.<br>
<br>
On 26.02.20, Maria Khaydich wrote:<br>
> <br>
> Looks like this patch caused some tests to fail according to Sasha (avtikhon).<br>
> I made another commit fixing the issue.<br>
> <br>
> ----------------------------------------------------------------------<br>
> Previous commit that was merged into master did not do<br>
> proper clean-up. That caused occasional failures of other<br>
> tests, all with the same error saying user 'guest' already<br>
> had access on universe.<br>
> <br>
> Closes #714<br>
> ---<br>
> Branch:<br>
> <a href="https://github.com/tarantool/tarantool/compare/eljashm/gh-714-box-schema-user-grant-invalid-error" target="_blank">https://github.com/tarantool/tarantool/compare/eljashm/gh-714-box-schema-user-grant-invalid-error</a> <br>
> <br>
> test/box/access.result | 18 ++++++++++++------<br>
> test/box/access.test.lua | 10 ++++++----<br>
> 2 files changed, 18 insertions(+), 10 deletions(-)<br>
> diff --git a/test/box/access.result b/test/box/access.result<br>
> index b454d0eaa..e351eaf2c 100644<br>
> --- a/test/box/access.result<br>
> +++ b/test/box/access.result<br>
> @@ -2113,23 +2113,29 @@ box.space._priv:delete{1, 'universe', 0}<br>
> -- i.e. error on universally granted privileges shouldn't<br>
> -- include any redundant details and/or symbols.<br>
> --<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'universe')<br>
> +box.schema.user.create('grantee')<br>
> ---<br>
> ...<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'universe')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'universe')<br>
> ---<br>
> -- error: User 'guest' already has read,write,execute access on universe<br>
> +...<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'universe')<br>
> +---<br>
> +- error: User 'grantee' already has read,write,execute access on universe<br>
> ...<br>
> -- Expected behavior of grant() error shouldn't change otherwise.<br>
> sp = box.schema.create_space('not_universe')<br>
> ---<br>
> ...<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'space', 'not_universe')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'space', 'not_universe')<br>
> +---<br>
> +...<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'space', 'not_universe')<br>
> ---<br>
> +- error: User 'grantee' already has read,write,execute access on space 'not_universe'<br>
> ...<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'space', 'not_universe')<br>
> +box.schema.user.drop('grantee')<br>
> ---<br>
> -- error: User 'guest' already has read,write,execute access on space 'not_universe'<br>
> ...<br>
> sp:drop()<br>
> ---<br>
> diff --git a/test/box/access.test.lua b/test/box/access.test.lua<br>
> index 387c8b06b..6be558247 100644<br>
> --- a/test/box/access.test.lua<br>
> +++ b/test/box/access.test.lua<br>
> @@ -812,11 +812,13 @@ box.space._priv:delete{1, 'universe', 0}<br>
> -- i.e. error on universally granted privileges shouldn't<br>
> -- include any redundant details and/or symbols.<br>
> --<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'universe')<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'universe')<br>
> +box.schema.user.create('grantee')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'universe')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'universe')<br>
> <br>
> -- Expected behavior of grant() error shouldn't change otherwise.<br>
> sp = box.schema.create_space('not_universe')<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'space', 'not_universe')<br>
> -box.schema.user.grant('guest', 'read,write,execute', 'space', 'not_universe')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'space', 'not_universe')<br>
> +box.schema.user.grant('grantee', 'read,write,execute', 'space', 'not_universe')<br>
> +box.schema.user.drop('grantee')<br>
> sp:drop()<br>
> -- <br>
> 2.24.0 <br>
> <br>
<br>
<snipped><br>
<br>
> <br>
> --<br>
> Maria Khaydich<br>
> <br>
> <br>
<br>
[1]: <a href="https://github.com/tarantool/test-run/issues/156" target="_blank">https://github.com/tarantool/test-run/issues/156</a><br>
<br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>