<HTML><BODY>Hi!<br><br>> Put a link to the issue below '---' delimiter next time.<br><br>Ok!<br><br>> Please, add a brief explanation to the commit message and then patch will<br>> be OK to push. Thanks.<br><br>When vinyl_run_size_ratio less then 2, LSM-tree could work incorrect.<br> <br> For example:<br> Suppose the L0 size is 100Mb, the ratio of run sizes at each LSM-tree<br> level is 1.5 and there can be no more than 2 runs per level (the variable<br> vinyl_run_count_per_level). After the first 3 dumps, the disk will contain<br> 3 runs of 100 Mb at L1. Let the dump contain many delete operations, so<br> the runs will be compacted into a single 200 Mb run. It will be moved to L2.<br> The next 3 dumps will produce 300 Mb run and it will be moved to L3,<br> because there could be only 150-225 Mb files at L2. the new file is<br> lower than the old one, what contradicts the basic idea of the tree LSM-tree.<br> Similarly with the vinyl_run_count_per_level = 1.<br><br>branch: <a href="https://github.com/maksimkulis/tarantool/tree/maksimkulis/bh-3346-fix-run-size-ratio" rel="noopener" target="_blank" data-mce-href="https://github.com/maksimkulis/tarantool/tree/maksimkulis/bh-3346-fix-run-size-ratio">https://github.com/maksimkulis/tarantool/tree/maksimkulis/bh-3346-fix-run-size-ratio</a><br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Пятница, 31 января 2020, 3:24 +03:00 от Nikita Pettik <korablev@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15804302521446027175_BODY">On 24 Jan 14:04, Maxim Kulis wrote:<br>
> <br>
> <br>
> Hi! <br>
> Yes, here is the new patch.<br>
> <br>
> Change the minimum possible value of the variable vinyl_run_size_ratio to 2. <br>
> <br>
> Closes #3346<br>
> <br>
> issue: <a href="https://github.com/tarantool/tarantool/issues/3346" target="_blank">https://github.com/tarantool/tarantool/issues/3346</a><br>
> ---<br>
<br>
Put a link to the issue below '---' delimiter next time.<br>
<br>
> >> >Finally, I would add brief explanation to the commit message why<br>
> >> >run_size_ratio less than 2 is meaningless (for those who are not<br>
> >> >familiar with vinyl inner organization).<br>
<br>
Please, add a brief explanation to the commit message and then patch will<br>
be OK to push. Thanks.<br>
<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Maxim Kulis<br></BODY></HTML>