<HTML><BODY>Igor,<br><br>Thanks for the review, I've changed the commit message as you suggested.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 15 января 2020, 2:25 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15790443370899203982_BODY">Sasha,<br>
<br>
Thanks, the patch LGTM, though as discussed offline I see no relation to<br>
ASAN. So I propose to reword the commit message as the following:<br>
| All local connection timeout settings not related to the testing<br>
| scenario are removed within this change. Instead of removed values the<br>
| default one from src/box/lua/load_cfg.lua will be used. The approach<br>
| with a single default value helps to avoid flaky test results<br>
| regarding different timeout values and makes the future maintainence<br>
| easier.<br>
|<br>
| The change is required for LSAN and ASAN testing machinery since it<br>
| introduces a little overhead and cause failures for tests with<br>
| excessively strict time limits.<br>
|<br>
| Needed for #2058<br>
<br>
Feel free to adjust it on your own way.<br>
<br>
On 21.11.19, Alexander V. Tikhonov wrote:<br>
> Removed all local connection timeout setups, where it is not the part<br>
> of the testing scenario. Instead of it the default value will be used.<br>
> Also it is more comfortable to change the single default value instead<br>
> of the change this value at each of the test scenarios, it will help<br>
> to avoid of flaky results in tests beacuse of different timeout vlaues.<br>
<br>
Typo: s/vlaues/values/.<br>
Typo: s/beacuse/because/.<br>
<br>
> The most of tests used the replication connection timeout is equal to<br>
> 0.5 second, while defualt value is set at sources file:<br>
<br>
Typo: s/defualt/default/.<br>
<br>
> src/box/lua/load_cfg.lua<br>
> to the value of 30 seconds:<br>
> replication_connect_timeout = 30<br>
> which is quite enough for all of the tests that don't need any special<br>
> values for it.<br>
> <br>
> Part of #2058<br>
> ---<br>
<br>
<snipped><br>
<br>
> -- <br>
> 2.17.1<br>
> <br>
<br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>