<HTML><BODY>Igor,<br><br>Thank you for all the reviews, I've squashed all changes into the single commit and sent<br>it on the review of A. Turenko.<br><br>Alexander, please proceed the review.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Понедельник, 13 января 2020, 20:04 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15789350750951974223_BODY">Sasha,<br>
<br>
Thanks, you've fixed almost everything. Sorry, two my remarks were<br>
slightly misleading, thus I extended them in the corresponding patch<br>
in this patchset. Please consider them, since everything else LGTM.<br>
<br>
I guess after the final fixes you can squash everithing into a single<br>
commit and ask Sasha Tu to proceed with the patch.<br>
<br>
On 13.01.20, Alexander V. Tikhonov wrote:<br>
<div class="mail-quote-collapse">> Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/gh-3380-push-packages-s3-full-ci" target="_blank">https://github.com/tarantool/tarantool/tree/avtikhon/gh-3380-push-packages-s3-full-ci</a><br>
> Issue: <a href="https://github.com/tarantool/tarantool/issues/3380" target="_blank">https://github.com/tarantool/tarantool/issues/3380</a><br>
> <br>
> v4: <a href="https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013568.html" target="_blank">https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013568.html</a><br>
> v3: <a href="https://lists.tarantool.org/pipermail/tarantool-patches/2019-December/013060.html" target="_blank">https://lists.tarantool.org/pipermail/tarantool-patches/2019-December/013060.html</a><br>
> v2: <a href="https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012352.html" target="_blank">https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012352.html</a><br>
> v1: <a href="https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/012021.html" target="_blank">https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/012021.html</a><br>
> <br>
> Changes v4:<br>
> - minor corrections<br>
> <br>
> Changes v3:<br>
> - common code parts merged to standalone routines<br>
> - corrected code style, minor updates<br>
> - script is ready for release<br>
> <br>
> Changes v2:<br>
> - made changes in script from draft to pre-release stages<br>
> <br>
> Alexander V. Tikhonov (3):<br>
> gitlab-ci: implement packing into MCS S3<br>
> Testing changes after 2nd review on S3<br>
> Testing changes after 3rd review on S3<br>
> <br>
> .gitlab-ci.yml | 5 +-<br>
> .gitlab.mk | 20 +-<br>
> .travis.mk | 41 ++-<br>
> tools/add_pack_s3_repo.sh | 527 ++++++++++++++++++++++++++++++++++++++<br>
> 4 files changed, 567 insertions(+), 26 deletions(-)<br>
> create mode 100755 tools/add_pack_s3_repo.sh<br>
> <br>
> -- <br>
> 2.17.1<br>
> <br>
</div><br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>