<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello, thanks for your patch!</p>
<p>Our documentation doesn't contain any mentions that fiber.create
can fail.</p>
<p>Could you please file an issue (or may be doc bot request) with
description in what cases user</p>
<p>can expect that fiber.create will fail. Usually users don't use
pcall for fiber.create and this fact can</p>
<p>be quite unexpected for them.<br>
</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 10/01/2020 17:27, Cyrill Gorcunov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200110142749.11577-1-gorcunov@gmail.com">
<pre class="moz-quote-pre" wrap="">Currently we use say_x to log if error happened.
Strictly speaking when madvise is used to relax
pressue on mm subsystem since we started to use
bigger stacks (due to libreadline increased memory
usage).
Same time mprotect usage is more sensitive -- we
setup guard pages with its help and when failing
it is definitely an error which we should not only
mention in logger but provide a caller diag error.
Here is an example from memcached
</pre>
</blockquote>
<p><span style="color: rgb(0, 0, 0); font-family: "San
Francisco", Arial, sans-serif; font-size: 15px; font-style:
normal; font-variant-ligatures: normal; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">--<span> </span></span><br
style="color: rgb(0, 0, 0); font-family: "San
Francisco", Arial, sans-serif; font-size: 15px; font-style:
normal; font-variant-ligatures: normal; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial;">
<span style="color: rgb(0, 0, 0); font-family: "San
Francisco", Arial, sans-serif; font-size: 15px; font-style:
normal; font-variant-ligatures: normal; font-variant-caps:
normal; font-weight: 400; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">Oleg Babin</span></p>
</body>
</html>