<HTML><BODY>Igor, thanks for the review, I've made changes as you asked for.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 18 декабря 2019, 19:03 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15766850371914359163_BODY">Sasha,<br>
<br>
Thanks for the patchset, I left several comments per patch, however in<br>
the first one I wrote a general one, but I think it's convenient to left<br>
it here too.<br>
<br>
I guess it's preferable to have a sole 'build:' tag for any patch<br>
related to the build system. Feel free to ignore and proceed if<br>
Sasha Tu. (he's already CCed as a second reviewer) has no remarks to the<br>
subj.<br>
<br>
On 10.12.19, Alexander V. Tikhonov wrote:<br>
<div class="mail-quote-collapse">> Made the following changes at Dockerfile for static build:<br>
> - changed 'wget' tool use to 'curl -O -L' to avoid of '500' HTTP<br>
> error respond from download servers<br>
> - changed the link from sourceforge to github to download<br>
> the icu4c sources, as suggested on icu4c web site<br>
> - added 'build' directory removement to avoid of old configuration<br>
> at build/curl which is used for curl building<br>
> - removed LD_LIBRARY_PATH environment from curl build, due to the<br>
> path is empty in real and is not needed<br>
> - added '-j' option to make tool calls for all builds to speed it up<br>
> in 4 times<br>
> - set Dockerfile WORKDIR from the very start of Tarantool sources<br>
> builds to make the Dockerfile code more readable and removed all<br>
> duplicating calls to Tarantool sources directory changes.<br>
> <br>
> Github: <a href="https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci" target="_blank">https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci</a><br>
> Issue: -<br>
> <br>
> Alexander V. Tikhonov (5):<br>
> static build: speedup build<br>
> static build: remove unneeded LD_LIBRARY_PATH<br>
> static build: cleanup Dockerfile<br>
> static build: added build subdirectory cleanup<br>
> static build: resolve issues with sourceforge.net<br>
> <br>
> Dockerfile.staticbuild | 37 +++++++++++++++++--------------------<br>
> 1 file changed, 17 insertions(+), 20 deletions(-)<br>
> <br>
> -- <br>
> 2.17.1<br>
> <br>
</div><br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>