<HTML><BODY>Igor, thanks for the review, I've made comment correction as you suggested<br> and added the link into the comment.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 18 декабря 2019, 18:03 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15766814100753064741_BODY">Sasha,<br>
<br>
Thanks, the patch LGTM. Please consider the comment I left in the first<br>
patch about the commit subject tag.<br>
<br>
Side note: I'm totally not a docker master and I guess links such as<br>
this one[1] can be very useful for further maintenance. Feel free to<br>
drop them into your next commit messages.<br>
<br>
On 10.12.19, Alexander V. Tikhonov wrote:<br>
<div class="mail-quote-collapse">> Set Dockerfile WORKDIR from the very start of Tarantool sources<br>
> builds to make the Dockerfile code more readable and removed all<br>
> duplicating calls to Tarantool sources directory changes.<br>
> ---<br>
> Dockerfile.staticbuild | 24 ++++++++++--------------<br>
> 1 file changed, 10 insertions(+), 14 deletions(-)<br>
> <br>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild<br>
> index 343627746..66342fa4e 100644<br>
> --- a/Dockerfile.staticbuild<br>
> +++ b/Dockerfile.staticbuild<br>
> @@ -64,30 +64,26 @@ RUN set -x && \<br>
> <br>
> COPY . /tarantool<br>
> <br>
> +WORKDIR /tarantool<br>
> +<br>
> RUN set -x && \<br>
> - cd tarantool && \<br>
> git submodule init && \<br>
> git submodule update<br>
> <br>
> -WORKDIR /tarantool<br>
> -<br>
> RUN set -x && \<br>
> find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \<br>
> find . -name 'CMakeCache.txt' -type f -delete<br>
> <br>
> RUN pip install -r /tarantool/test-run/requirements.txt<br>
> <br>
> -RUN set -x \<br>
> - && (cd /tarantool; \<br>
> - cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \<br>
> - -DENABLE_DIST:BOOL=ON \<br>
> - -DBUILD_STATIC=ON \<br>
> - -DOPENSSL_USE_STATIC_LIBS=ON \<br>
> - -DOPENSSL_ROOT_DIR=/usr/local \<br>
> - .) \<br>
> - && make -C /tarantool -j<br>
> -<br>
> -RUN cd /tarantool && make install<br>
> +RUN set -x && \<br>
> + cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \<br>
> + -DENABLE_DIST:BOOL=ON \<br>
> + -DBUILD_STATIC=ON \<br>
> + -DOPENSSL_USE_STATIC_LIBS=ON \<br>
> + -DOPENSSL_ROOT_DIR=/usr/local \<br>
> + . && \<br>
> + make -j && make install<br>
> <br>
> ARG RUN_TESTS<br>
> RUN if [ -n "${RUN_TESTS}" ]; then \<br>
> -- <br>
> 2.17.1<br>
> <br>
</div><br>
[1]: <a href="https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#workdir" target="_blank">https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#workdir</a><br>
<br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>