<HTML><BODY>Igor, thanks for the review, I've changed comment as you suggested<br>and added the same comment into the Dockerfile.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 18 декабря 2019, 18:37 +03:00 от Igor Munkin <imun@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15766834240320726003_BODY">Sasha,<br>
<br>
Thanks for the patch! I left two comments below, please consider them.<br>
<br>
On 10.12.19, Alexander V. Tikhonov wrote:<br>
> Added 'build' directory removement to avoid of old configuration<br>
> at build/curl which is used for curl building.<br>
<br>
The commit message looks a bit complex. I rewrote it a little, as the<br>
following:<br>
| Added the command for 'build' directory cleanup. It purges all<br>
| artefacts produced for curl build, including the old configuration in<br>
| build/curl.<br>
Feel free to adjust the commit message in your own way.<br>
<br>
> ---<br>
> Dockerfile.staticbuild | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild<br>
> index 66342fa4e..0424179a2 100644<br>
> --- a/Dockerfile.staticbuild<br>
> +++ b/Dockerfile.staticbuild<br>
> @@ -72,7 +72,8 @@ RUN set -x && \<br>
> <br>
> RUN set -x && \<br>
> find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \<br>
> - find . -name 'CMakeCache.txt' -type f -delete<br>
> + find . -name 'CMakeCache.txt' -type f -delete && \<br>
<br>
Please drop a comment about the build directory source, since it's not<br>
created (or even mentioned) within Docker file.<br>
<br>
> + rm -rf build<br>
> <br>
> RUN pip install -r /tarantool/test-run/requirements.txt<br>
> <br>
> -- <br>
> 2.17.1<br>
> <br>
<br>
-- <br>
Best regards,<br>
IM<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>