<HTML><BODY>From my side the fix is needed and the patch LGTM.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Пятница, 13 декабря 2019, 22:05 +03:00 от Ilya Kosarev <i.kosarev@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15762639170636637300_BODY">Under high load we might need to wait for all tuples to get to replica.<br>
With apllied fixes join_vclock test is not fragile anymore.<br>
<br>
Closes #4160<br>
---<br>
Branch: <a href="https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4160-fix-join-vclock-test" target="_blank">https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4160-fix-join-vclock-test</a><br>
Issue: <a href="https://github.com/tarantool/tarantool/issues/4160" target="_blank">https://github.com/tarantool/tarantool/issues/4160</a><br>
<br>
test/replication/join_vclock.result | 5 +----<br>
test/replication/join_vclock.test.lua | 3 +--<br>
test/replication/suite.ini | 1 -<br>
3 files changed, 2 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/test/replication/join_vclock.result b/test/replication/join_vclock.result<br>
index a9781073d44..eb05f1f1a02 100644<br>
--- a/test/replication/join_vclock.result<br>
+++ b/test/replication/join_vclock.result<br>
@@ -67,10 +67,7 @@ test_run:cmd("switch replica1")<br>
---<br>
- true<br>
...<br>
-cnt = box.space.test.index[0]:count()<br>
----<br>
-...<br>
-box.space.test.index.primary:max()[1] == cnt - 1<br>
+test_run:wait_cond(function() return box.space.test.index.primary:max()[1] == box.space.test.index.primary:count() - 1 end, 10)<br>
---<br>
- true<br>
...<br>
diff --git a/test/replication/join_vclock.test.lua b/test/replication/join_vclock.test.lua<br>
index 0b60dffc2c0..08c3a26442b 100644<br>
--- a/test/replication/join_vclock.test.lua<br>
+++ b/test/replication/join_vclock.test.lua<br>
@@ -26,8 +26,7 @@ ch:get()<br>
<br>
errinj.set("ERRINJ_RELAY_FINAL_SLEEP", false)<br>
test_run:cmd("switch replica1")<br>
-cnt = box.space.test.index[0]:count()<br>
-box.space.test.index.primary:max()[1] == cnt - 1<br>
+test_run:wait_cond(function() return box.space.test.index.primary:max()[1] == box.space.test.index.primary:count() - 1 end, 10)<br>
test_run:cmd("switch default")<br>
<br>
replica_set.drop_all(test_run)<br>
diff --git a/test/replication/suite.ini b/test/replication/suite.ini<br>
index 384dac677ea..ed1de31405e 100644<br>
--- a/test/replication/suite.ini<br>
+++ b/test/replication/suite.ini<br>
@@ -12,7 +12,6 @@ long_run = prune.test.lua<br>
is_parallel = True<br>
pretest_clean = True<br>
fragile = errinj.test.lua ; gh-3870<br>
- join_vclock.test.lua ; gh-4160<br>
long_row_timeout.test.lua ; gh-4351<br>
skip_conflict_row.test.lua ; gh-4457<br>
sync.test.lua ; gh-3835 gh-3877<br>
-- <br>
2.17.1<br>
<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>