<HTML><BODY><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Hi!</span><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Thanks for your review.<br><br></span>Sent v3 of the patchset considering mentioned drawbacks.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Воскресенье, 24 ноября 2019, 18:53 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15746108211846929835_BODY">Hi!<br>
<br>
Please, specify branch and issue links.<br>
<br>
Issue: <a href="https://github.com/tarantool/tarantool/issues/4586" target="_blank">https://github.com/tarantool/tarantool/issues/4586</a><br>
Branch: <a href="https://github.com/tarantool/tarantool/commits/i.kosarev/gh-4586-fix-quorum-test" target="_blank">https://github.com/tarantool/tarantool/commits/i.kosarev/gh-4586-fix-quorum-test</a><br>
<br>
Add 'Changes in V2' section, when you send a new version.<br>
<br>
On 23/11/2019 22:53, Ilya Kosarev wrote:<br>
> This patchset fixes appliers pruning in replicaset_update, anon<br>
> replicas iteration issues in replicaset_follow and stabilizes quorum<br>
> test. It also stabilizes tcp_connect in test_run:cmd().<br>
> <br>
> Ilya Kosarev (4):<br>
> test: update test-run<br>
> replication: fix appliers pruning<br>
> replication: make anon replicas iteration safe<br>
> test: stabilize quorum test conditions<br>
> <br>
> src/box/replication.cc | 17 +++---<br>
> test-run | 2 +-<br>
> .../box_set_replication_stress.result | 38 +++++++++++++<br>
> .../box_set_replication_stress.test.lua | 17 ++++++<br>
> test/replication/quorum.result | 54 ++++++++++++++-----<br>
> test/replication/quorum.test.lua | 24 +++++----<br>
> 6 files changed, 121 insertions(+), 31 deletions(-)<br>
> create mode 100644 test/replication/box_set_replication_stress.result<br>
> create mode 100644 test/replication/box_set_replication_stress.test.lua<br>
> <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Ilya Kosarev<br></BODY></HTML>