<HTML><BODY><p>Igor,<br><br>Thanks a lot for the review, I've made the changes in commit messages as you suggested, please review the branch commit logs.<br><br></p><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Суббота, 16 ноября 2019, 16:09 +03:00 от Igor Munkin <imun@tarantool.org>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15739097611116410451_BODY">Sasha,<br><br>
I took a look onto changeset within<br>
avtikhon/gh-4601-tests-backport-110-full-ci that need to be ported to<br>
1.10. Thanks, it LGTM in general, but please consider my minor comments<br>
below.<br><br>
On 31.10.19, Alexander V. Tikhonov wrote:<br>
> Backport the test patches at 1.10 from master<br>
> <br>
> Backported 12 patches from master to 1.10 branch to be<br>
> able to run 1.10 testing in parallel:<br>
> <br>
> Alexander Tikhonov (1):<br>
> test: wait for xlog/snap/log file changes<br>
LGTM.<br>
> <br>
> Alexander Turenko (4):<br>
> test: enable cleaning of a test environment<br>
LGTM.<br>
> test: allow to run replication/misc multiple times<br>
LGTM. Side note: there is a tool for reloading modules with C structures<br>
defined via FFI[1].</div></div></div></div></blockquote>Ok.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15739097611116410451_BODY"><br>
> test: increase timeouts in replication/errinj<br>
LGTM.<br>
> test: increase timeouts in replication/misc<br>
LGTM.<br>
> <br>
> Sergei Voronezhskii (6):<br>
> test: enable parallel mode for xlog tests<br>
LGTM.<br>
> test: enable parallel run for long test suites<br>
LGTM with minor note: consider adjusting the part of commit message<br>
related to luajit-tap.</div></div></div></div></blockquote>Removed information about luajit-tap.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15739097611116410451_BODY"><br>
> test: replication parallel mode on<br>
LGTM.<br>
> test: use wait_cond to check follow status<br>
LGTM.<br>
> test: put require in proper places<br>
LGTM.<br>
> test: errinj for pause relay_send<br>
LGTM with minor note: applying this patch makes history a bit messy. I<br>
see marking these changes as a follow-up for 8f2bd5010 commit is a<br>
convenient way to avoid being confused in future.</div></div></div></div></blockquote>Removed all information that is not from the current commit. Also added information about the cherry-pick story of the whole patch.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15739097611116410451_BODY"><br>
> <br>
> avtikhon (1):<br>
> test: fix replication/gc flaky failures<br>
LGTM.<br>
> <br>
> test/app-tap/suite.ini | 1 +<br>
> test/app/suite.ini | 1 +<br>
> test/box-tap/suite.ini | 1 +<br>
> test/box/box.lua | 4 +-<br>
> test/box/suite.ini | 1 +<br>
> test/engine/box.lua | 21 -----<br>
> test/engine/suite.ini | 1 +<br>
> test/engine_long/suite.ini | 3 +-<br>
> test/engine_long/suite.lua | 5 +-<br>
> test/long_run-py/suite.ini | 2 +-<br>
> test/replication/catch.test.lua | 1 -<br>
> test/replication/errinj.result | 8 +-<br>
> test/replication/errinj.test.lua | 8 +-<br>
> test/replication/gc.result | 108 ++++++++++++-----------<br>
> test/replication/gc.test.lua | 80 +++++++++--------<br>
> test/replication/gc_no_space.result | 18 ++--<br>
> test/replication/gc_no_space.test.lua | 18 ++--<br>
> test/replication/lua/rlimit.lua | 2 +-<br>
> test/replication/misc.result | 52 ++++-------<br>
> test/replication/misc.test.lua | 34 +++----<br>
> test/replication/on_replace.result | 3 +<br>
> test/replication/on_replace.test.lua | 1 +<br>
> test/replication/replica_rejoin.result | 10 +--<br>
> test/replication/replica_rejoin.test.lua | 6 +-<br>
> test/replication/suite.ini | 3 +-<br>
> test/replication/sync.result | 2 +-<br>
> test/replication/sync.test.lua | 2 +-<br>
> test/vinyl/suite.ini | 1 +<br>
> test/wal_off/suite.ini | 1 +<br>
> test/xlog/suite.ini | 3 +-<br>
> 30 files changed, 200 insertions(+), 201 deletions(-)<br>
> <br>
> -- <br>
> 2.17.1<br>
> <br><br>
[1]: <a href="https://github.com/moonlibs/ffi-reloadable" target="_blank">https://github.com/moonlibs/ffi-reloadable</a><br><br>
-- <br>
Best regards,<br>
IM<br><br></div></div></div></div></blockquote>
<br>
<br>-- <br>Alexander Tikhonov<br></BODY></HTML>