<HTML><BODY><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Hi!</span><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Thanks for your review.<br><br></span><p>In already provided v5 of this patchset patches 1, 2 & 4 are fixed<br>according to review comments.<br>Detailed answer for patch 3 review is also sent.</p><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 29 октября 2019, 2:43 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15723062011466892384_BODY">Hi!<br>
<br>
Thanks for all that work on the http client.<br>
<br>
I mostly okay with the code itself (however there are moments where I'm<br>
tentiative in the patch re CURLOPT_ERRORBUFFER), but I would larify<br>
messages around.<br>
<br>
I'll comment each patch separately.<br>
<br>
WBR, Alexander Turenko.<br>
<br>
On Mon, Oct 28, 2019 at 08:11:11PM +0300, Ilya Kosarev wrote:<br>
> This patchset introduces CURLOPT_ACCEPT_ENCODING option. It brought up<br>
> fix for CURLE_WRITE_ERROR processing and addition of<br>
> CURLE_BAD_CONTENT_ENCODING in curl request code processing, as well as<br>
> enhancement of provided error info for curl request.<br>
> <br>
> Changes in v2:<br>
> - added docbot request<br>
> - fixed comments<br>
> - enhanced httpc_set_accept_encoding description<br>
> - fixed error handling for unsupported encodings<br>
> <br>
> Changes in v3:<br>
> - moved error handling for unsupported encodings fix to separate commit<br>
> - added error message obtained using CURLOPT_ERRORBUFFER option<br>
> - added CURLE_BAD_CONTENT_ENCODING for curl request code processing<br>
> <br>
> Changes in v4:<br>
> - fixed commit message in PATCH 2/4<br>
> - added test case for error message obtained using CURLOPT_ERRORBUFFER option<br>
> <br>
> Branch: <a href="https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4232-curlopt-accept-encoding" target="_blank">https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4232-curlopt-accept-encoding</a><br>
> Issues: <a href="https://github.com/tarantool/tarantool/issues/4232" target="_blank">https://github.com/tarantool/tarantool/issues/4232</a><br>
> <a href="https://github.com/tarantool/tarantool/issues/4578" target="_blank">https://github.com/tarantool/tarantool/issues/4578</a><br>
> <a href="https://github.com/tarantool/tarantool/issues/4579" target="_blank">https://github.com/tarantool/tarantool/issues/4579</a><br>
> <br>
> Ilya Kosarev (4):<br>
> http: add CURLOPT_ACCEPT_ENCODING option<br>
> http: remove redundant & incorrect case for curl_request code<br>
> http: enrich httpc_request with curl error message buffer<br>
> http: add CURLE_BAD_CONTENT_ENCODING case for curl_request code<br>
> <br>
> src/httpc.c | 24 +++++++++++++++++++-----<br>
> src/httpc.h | 29 +++++++++++++++++++++++++++++<br>
> src/lua/httpc.c | 9 +++++++++<br>
> src/lua/httpc.lua | 2 ++<br>
> test/app-tap/http_client.test.lua | 4 +++-<br>
> 5 files changed, 62 insertions(+), 6 deletions(-)<br>
> <br>
> -- <br>
> 2.17.1<br>
> <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Ilya Kosarev<br></BODY></HTML>