<HTML><BODY><p>Sasha,<br><br>Thanks for you review.</p><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 10 сентября 2019, 16:58 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681238871681628105_BODY">I found the following difference with the current master:<br><br>
| --- a/luajit-tap/fold_bug_LuaJIT_505.test.lua 2019-09-10 15:45:04.886639461 +0300<br>
| +++ b/test/fold_bug_LuaJIT_505.test.lua 2019-09-10 15:44:22.221641210 +0300<br>
| @@ -8,7 +8,8 @@<br>
| -- Test file to demonstrate Lua fold machinery icorrect behavior, details:<br>
| -- <a href="https://github.com/LuaJIT/LuaJIT/issues/505" target="_blank">https://github.com/LuaJIT/LuaJIT/issues/505</a><br>
| <br>
| -jit.opt.start("hotloop=1")<br>
| +jit.opt.start(0, "hotloop=1")<br>
| +require('jit.dump').start("+bti", "505.trace")<br>
| for _ = 1, 20 do<br>
| local value = "abc"<br>
| local pos_c = string.find(value, "c", 1, true)<br><br>
From what it appears? If it is necessary, then move it to its own commit<br>
or describe in the commit message.</div></div></div></div></blockquote>The difference you found is an artefact left after investigation of the problem related to string.find recording. These changes are not required within this patch.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681238871681628105_BODY"><br><br>
Please, base your branch on top of a last commit in a default branch<br>
(named 'tarantool'). Now it contains one extra commit ('luajit: fix<br>
string.find recording').</div></div></div></div></blockquote><p>Another artefact.<br></p><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681238871681628105_BODY"><br><br>
Verified in-source build, works ok.<br><br>
Tried out-of-source build: small and luajit-tap tests are not run (just<br>
not found).<br><br>
If we'll create just symlinks in 'test' repository directory and will<br>
remove creating symlinks from test/CMakeLists.txt, then luajit-tap would<br>
work good, but small tests would not be built (and so small tests will<br>
be found).<br><br>
It seems it is subject for a separate issue: don't sure about test-run<br>
or tarantool. Something was changed in test-run I guess; maybe here:<br><a href="https://github.com/tarantool/test-run/commit/b42093abc0e7fe895ff0ac7c0685d016c783b3a1" target="_blank">https://github.com/tarantool/test-run/commit/b42093abc0e7fe895ff0ac7c0685d016c783b3a1</a><br><br>
Don't sure whether it worth to block on this problem or file an issue<br>
and going on. Please, ask Kirill for that.<br><br>
Other then that everything look okay for me.</div></div></div></div></blockquote>I've already fixed all mentioned flaws in the feature branch and forcely update the corresponding remote branch. Please inform me whether a new patch is required to be sent.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681238871681628105_BODY"><br><br>
WBR, Alexander Turenko.<br><br>
On Thu, Sep 05, 2019 at 05:20:07PM +0300, Igor Munkin wrote:<br><div class="mail-quote-collapse">> Introduced structure has the following benefits:<br>
> * Excess testing machinery currently is not required directly in<br>
> luajit repo considering whole CI process setup for tarantool and its<br>
> static linking with libluajit<br>
> * All new tests related to luajit fixes and enhancements can be added<br>
> within a single patch with the corresponding changeset<br>
> <br>
> NB!: All added test chunks use tarantool tap module<br>
> ---<br>
> test/fold_bug_LuaJIT_505.test.lua | 21 +++<br>
> test/gh.test.lua | 17 +++<br>
> test/suite.ini | 5 +<br>
> test/table_chain_bug_LuaJIT_494.test.lua | 178 +++++++++++++++++++++++<br>
> test/unsink_64_kptr.test.lua | 44 ++++++<br>
> 5 files changed, 265 insertions(+)<br>
> create mode 100755 test/fold_bug_LuaJIT_505.test.lua<br>
> create mode 100755 test/gh.test.lua<br>
> create mode 100644 test/suite.ini<br>
> create mode 100755 test/table_chain_bug_LuaJIT_494.test.lua<br>
> create mode 100755 test/unsink_64_kptr.test.lua<br></div></div></div></div></div></blockquote>
<br><p>-- <br>IM</p><br></BODY></HTML>