<HTML><BODY><p>Sasha,<br><br>Thanks for you review.<br></p><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 10 сентября 2019, 17:17 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681250380456303551_BODY">Maybe update the commit to update luajit submodule here, when we'll push<br>
the patch to the luajit default branch (named 'tarantool')?<br><br>
While we are here, it worth to update the branch in .gitmodules (now it<br>
points to 'tarantool-1.7', but should point to 'tarantool'). If one will<br>
use git submodule update --remote, then it can confuse. Can be done<br>
right in this commit, just mention it in the commit message.<br></div></div></div></div></blockquote>Totally agree with your remark and as discussed I propose the following:<br><ol><li>Update submodule to the required branch within a separate commit (not included in current branch)<br data-mce-bogus="1"></li><li>Apply the patch with luajit-tap tests to tarantool/luajit repo (the patch mentioned below)<br data-mce-bogus="1"></li><li>Apply another patch removing corresponding tests from tarantool source tree<br data-mce-bogus="1"></li></ol>Kirill, if you have another workflow for such modifications, I'm open for a discussion.<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15681250380456303551_BODY"><br>
Out-of-source build missed small and luajit-tap test suites (it is<br>
already so for small). Don't sure whether it should block the commit.<br>
See more in the luajit's patch review:<br><a href="https://www.freelists.org/post/tarantool-patches/PATCH-11-test-add-tests-from-tarantool-source-tree,1" target="_blank">https://www.freelists.org/post/tarantool-patches/PATCH-11-test-add-tests-from-tarantool-source-tree,1</a><br><br>
WBR, Alexander Turenko.<br><br>
On Thu, Sep 05, 2019 at 05:01:53PM +0300, Igor Munkin wrote:<br><div class="mail-quote-collapse">> * All test chunks related to luajit were moved from tarantool source<br>
> tree to the luajit repo<br>
> * Adjusted CMakeLists via creating a symlink to luajit test directory<br>
> to fix out-of-source tests<br>
> <br>
> Closed #4478<br>
> ---<br>
> .gitignore | 1 +<br>
> test/CMakeLists.txt | 10 +<br>
> test/luajit-tap/fold_bug_LuaJIT_505.test.lua | 20 --<br>
> test/luajit-tap/gh.test.lua | 17 --<br>
> test/luajit-tap/suite.ini | 5 -<br>
> .../table_chain_bug_LuaJIT_494.test.lua | 178 ------------------<br>
> test/luajit-tap/unsink_64_kptr.test.lua | 44 -----<br>
> 7 files changed, 11 insertions(+), 264 deletions(-)<br>
> delete mode 100755 test/luajit-tap/fold_bug_LuaJIT_505.test.lua<br>
> delete mode 100755 test/luajit-tap/gh.test.lua<br>
> delete mode 100644 test/luajit-tap/suite.ini<br>
> delete mode 100755 test/luajit-tap/table_chain_bug_LuaJIT_494.test.lua<br>
> delete mode 100755 test/luajit-tap/unsink_64_kptr.test.lua<br></div></div></div></div></div></blockquote>
<br>
<br><p>-- <br>IM</p><br></BODY></HTML>