<HTML><BODY>Hi!<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Вторник, 23 июля 2019, 12:40 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15638748440468376418_BODY">> I addressed this issue in a patch to tarantool/libyaml. Please check it out.<br>
> This patch remains intact.<br><br>
Okay. I don't have objections, but one comment.<br><br>
> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w")<br>
> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99")<br><br>
Maybe it worth to declare a loop variable outside a loop initialization<br>
statement in libyaml (and update the upstream PR)? I mean that if all<br>
libyaml code follow C89, then we maybe should do it too in our changes.<br>
What do you think?</div></div></div></div></blockquote><br>This seems reasonable.<br>I updated both branches<br>(<a style="font-family: Helvetica, Arial, Tahoma, Verdana, sans-serif;" href="https://github.com/tarantool/libyaml/tree/sp/static-linking" rel="noopener" target="_blank" data-mce-href="https://github.com/tarantool/libyaml/tree/sp/static-linking" data-mce-style="font-family: Helvetica, Arial, Tahoma, Verdana, sans-serif;">https://github.com/tarantool/libyaml/tree/sp/static-linking</a> and <br><a style="font-family: Helvetica, Arial, Tahoma, Verdana, sans-serif;" href="https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci" rel="noopener" target="_blank" data-mce-href="https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci" data-mce-style="font-family: Helvetica, Arial, Tahoma, Verdana, sans-serif;">https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci</a>)<br>I've also updated the pull request to libyaml upstream.<br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15638748440468376418_BODY"><br><br></div></div></div></div></blockquote>
<br>
<br>-- <br>Sergey Petrenko<br></BODY></HTML>