<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">16 июля 2019 г., в 21:31, Konstantin Osipov <<a href="mailto:kostja@tarantool.org" class="">kostja@tarantool.org</a>> написал(а):</div><br class="Apple-interchange-newline"><div class=""><div class="">* Serge Petrenko <<a href="mailto:sergepetrenko@tarantool.org" class="">sergepetrenko@tarantool.org</a>> [19/07/16 16:44]:<br class=""><blockquote type="cite" class="">Before the patch IS_PRINTABLE macros was used<br class="">to determine if given character is printable or not.<br class="">This macros did not take into account characters<br class="">encoded with 4 bytes.<br class="">After the patch IS_PRINTABLE is replaced with new<br class="">corresponding function. Now the range of printable<br class="">characters is: (libyaml old range) U (icu range). This<br class="">new range include characters encoded with 4 bytes.<br class=""><br class=""></blockquote><br class="">Please don't forget to upstream the patch to the maintainer once<br class="">it's reviewed.<br class=""></div></div></blockquote><div><br class=""></div>Ok</div><div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">Has there been any changes in the upstream which we should be<br class="">aware of?<br class=""></div></div></blockquote><div><br class=""></div><div>None that I’m aware of.</div><div>Similar issues are still open in the libyaml repo.</div><div><a href="https://github.com/yaml/libyaml/issues/110" class="">https://github.com/yaml/libyaml/issues/110</a></div><div>The code dealing with printable unicode characters in libyaml</div><div>remains the same, it doesn’t deal with codepoints outside of</div><div>the Basic Multilingual Plane (every code point > 0xFFFF)</div><div><a href="https://github.com/yaml/libyaml/blob/master/src/yaml_private.h#L261" class="">https://github.com/yaml/libyaml/blob/master/src/yaml_private.h#L261</a></div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">On another note, since we're switching to Lua emitter as the<br class="">defualt one quite soon, we can perhaps close #4090 as won't fix<br class="">rather than bother improving libyaml.</div></div></blockquote><blockquote type="cite" class=""><div class=""><div class=""><br class=""><blockquote type="cite" class="">Related to tarantool/tarantool#4090<br class=""></blockquote><br class="">-- <br class="">Konstantin Osipov, Moscow, Russia<br class=""></div></div></blockquote><br class=""></div><div><div>--</div><div>Serge Petrenko</div><div><a href="mailto:sergepetrenko@tarantool.org" class="">sergepetrenko@tarantool.org</a></div><div class=""><br class=""></div></div><br class=""></body></html>