<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 4/29/19 2:35 AM, n.pettik wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0CEB3ED4-A19F-49FE-A074-5BD174D7FCF4@tarantool.org">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 26 Apr 2019, at 10:37, Mergen Imeev <<a
href="mailto:imeevma@tarantool.org" class=""
moz-do-not-send="true">imeevma@tarantool.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">On Mon, Apr 15, 2019 at 06:19:34PM
+0300, n.pettik wrote:</span><br style="caret-color:
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; text-decoration: none;"
class="">
<blockquote type="cite" style="font-family: Helvetica;
font-size: 12px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal;
orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none;"
class="">'make ... the only errcode of OP_Halt’ -><br
class="">
make … be the only ...<br class="">
<br class="">
<blockquote type="cite" class="">On 12 Apr 2019, at 15:34,<span
class="Apple-converted-space"> </span><a
href="mailto:imeevma@tarantool.org" class=""
moz-do-not-send="true">imeevma@tarantool.org</a><span
class="Apple-converted-space"> </span>wrote:<br
class="">
<br class="">
After this patch, the only error code that the OP_Halt
opcode<br class="">
will work with is SQL_TARANTOOL_ERROR.<br class="">
</blockquote>
<br class="">
So, why do we need it at all now? Let’s use simple flag<br
class="">
is_aborted like in parser.<br class="">
<br class="">
</blockquote>
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">I could not do it now.</span></div>
</blockquote>
<blockquote type="cite" class="">
<div class=""><span style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">I think we will do this when rc is
one of</span><br style="caret-color: rgb(0, 0, 0);
font-family: Helvetica; font-size: 12px; font-style:
normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">SQL_OK, SQL_ROW, SQL_DONE or
SQL_TARANTOOL_ERROR. This will be in</span><br
style="caret-color: rgb(0, 0, 0); font-family: Helvetica;
font-size: 12px; font-style: normal; font-variant-caps:
normal; font-weight: normal; letter-spacing: normal;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; word-spacing: 0px;
-webkit-text-stroke-width: 0px; text-decoration: none;"
class="">
<span style="caret-color: rgb(0, 0, 0); font-family:
Helvetica; font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration: none; float: none; display: inline
!important;" class="">the next patch-set.</span><br
class="">
</div>
</blockquote>
<div><br class="">
</div>
<div>That’s OK, but still don’t understand what prevents you
from</div>
<div>doing it right now..BTW, I don’t see corresponding patch in
the</div>
<div>patch-set you’ve already sent (next one).</div>
</div>
</blockquote>
The rc field is used to return some information from functions<br>
that return an error code in case something went wrong. In this<br>
regard, I think that we can completely remove this field instead<br>
of replacing it with is_aborted. However, after I tried to do<br>
this, I found that at the moment it had too many connections with<br>
the code. I'm not quite sure that it will be safe to remove the rc<br>
field right now. I would suggest removing some unused modules and<br>
reworking the memory system into SQL before we remove the rc field<br>
from the Vdbe structure.<br>
</body>
</html>