<HTML><BODY><br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 3 апреля 2019, 20:19 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15543119450000000378_BODY">On Wed, Apr 03, 2019 at 07:58:38PM +0300, <a href="mailto:imeevma@tarantool.org">imeevma@tarantool.org</a> wrote:<br>
> >> diff --git a/src/box/sql.c b/src/box/sql.c<br>
> >> index 4fac020..7beeee1 100644<br>
> >> --- a/src/box/sql.c<br>
> >> +++ b/src/box/sql.c<br>
> >> @@ -87,7 +87,7 @@ sql_load_schema()<br>
> >> * statistics (_sql_stat1 and _sql_stat4). Thus, we can<br>
> >> * skip statistics loading.<br>
> >> */<br>
> >> - struct space *stat = space_by_id(BOX_SQL_STAT1_ID);<br>
> >> + struct space *stat = space_by_name("_sql_stat1");<br>
> ><br>
> > I don't understand this change: even though you removed the tables you<br>
> > still expect them to be accessible by name here and in a few other<br>
> > places. At any rate, the comment above needs to be refreshed.<br>
> ><br>
> I did this to free BOX_SQL_STAT1_ID and BOX_SQL_STAT4_ID so I<br>
> could remove them. These functions are currently unused. Moved<br>
> this fix to a different commit.<br>
<br>
Okay. Still, I don't understand how this is supposed to work at all:<br>
the tables have been removed, but the code using them is still there -<br>
it just refers to them by name instead of id now.<br>
</div>
</div>
</div>
</div>
</blockquote>Currently I do not know how to change these functions in another<br>way, since there are no spaces to use instead of _sql_stat1 and<br>_sql_stat4. I will rework these functions later when a new concept<br>of SQL statistics appears.<br></BODY></HTML>