<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Guys, please, don’t ignore this patch. It is vital for 2.1.1 release.<div class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 20 Mar 2019, at 18:38, Kirill Shcherbatov <<a href="mailto:kshcherbatov@tarantool.org" class="">kshcherbatov@tarantool.org</a>> wrote:</div><div class=""><div style="" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" class=""><blockquote type="cite" class="">Tarantool could not start from the snapshot created by version<br class="">2.1.0 because the new version 2.1.1 does not support the<br class="">index.opts.sql index opt and stops the execution.<br class="">Introduced a special state OPT_DEF_LEGACY macro to ignore legacy<br class="">options and introduced migration code in upgrade.lua.<br class=""></blockquote><br class="">As for me, it looks satisfying, but I strongly recommend you to ask<br class="">other members of server team for comments on this approach.<br class="">Will there be other “legacy” options, or in the nearest future this is<br class="">going to be the only one? Moreover, opts_parse_key already features<br class="">“skip_unknown_options” param - could we skip “sql” option using it<br class="">(ofc considering some workaround)?<br class=""><br class="">Again, since it is not directly related to the main patch-set, let’s<br class="">consider it as independent.<span class="Apple-converted-space"> </span><br class=""></blockquote><br class="">LGTM.<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I've rebased this separate patch on the branch<span class="Apple-converted-space"> </span></span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">kshch/migration-fixup</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">you may cherry-pick it if it is really reasonable.</span></div></div></blockquote></div><br class=""></div></div></body></html>