<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 26 Feb 2019, at 16:33, i.koptelov <<a href="mailto:ivan.koptelov@tarantool.org" class="">ivan.koptelov@tarantool.org</a>> wrote:</div><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">On 25 Feb 2019, at 18:10, n.pettik <<a href="mailto:korablev@tarantool.org" class="">korablev@tarantool.org</a>> wrote:<br class=""><br class="">That’s I was talking about. But using the macros with the same<br class="">name as in utf library doesn’t look like a good pattern. Yep, you<br class="">can use define guards like:<br class=""><br class="">#ifdef U8_COUNT_TRAIL_BYTES_UNSAFE<br class="">#undef U8_COUNT_TRAIL_BYTES_UNSAFE<br class="">#endif<br class="">#define U8_COUNT_TRAIL_BYTES_UNSAFE<br class=""><br class="">But I’d rather just give it another name.<br class="">Hence, taking into account comment below,<br class="">we are going to substitute SQL_SKIP_UTF8() with<br class="">implementation borrowed from icu library.<br class=""></blockquote><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I changed the names to SQL_UTF8_FWD_1_UNSAFE and</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">SQL_UTF8_COUNT_TRAIL_BYTES_UNSAFE.</span></div></blockquote><br class=""></div><div>Won’t bother you with portion of minor comments.</div><div>I’ve pushed them, take a look. If they are OK, just</div><div>squash (but don’t squash last commit) them and</div><div>patch will be OK as well.</div><div><br class=""></div><div>Also, I’ve fixed a bit commit message. Add please</div><div>doc request which includes user-visible changes.</div></body></html>