<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 4 Feb 2019, at 22:11, Ivan Koptelov <<a href="mailto:ivan.koptelov@tarantool.org" class="">ivan.koptelov@tarantool.org</a>> wrote:</div><div class=""><blockquote type="cite" cite="mid:F7CB4F08-B647-444D-A028-C6BB6954E6AE@tarantool.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""><blockquote type="cite" class=""><pre class="moz-quote-pre" wrap="">On 4 Feb 2019, at 18:34, Ivan Koptelov <a class="moz-txt-link-rfc2396E" href="mailto:ivan.koptelov@tarantool.org"><ivan.koptelov@tarantool.org></a> wrote:
Removes obsolete tests on ORDER BY/LIMIT + DELETE. This
functionality was not supported for some time, but a few tests
were still existing.
Closes #2172
---
Branch <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete">https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete</a>
Issue <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/issues/2172">https://github.com/tarantool/tarantool/issues/2172</a>
test/sql-tap/e_delete.test.lua | 188 -----------------------------------------
1 file changed, 188 deletions(-)
diff --git a/test/sql-tap/e_delete.test.lua b/test/sql-tap/e_delete.test.lua
index 84a4e0a22..0a81eb3bd 100755
--- a/test/sql-tap/e_delete.test.lua
+++ b/test/sql-tap/e_delete.test.lua
@@ -305,194 +305,6 @@ if (0 > 0) then
DELETE FROM t8 NOT INDEXED WHERE a=5;
END;]], {"NOT INDEXED"}},
})
- -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses (described
- -- below) are unsupported for DELETE statements within triggers.
- —
</pre></blockquote><pre class="moz-quote-pre" wrap="">If I’m not mistaken, tests starting from e_delete-2.0 are disabled
(under if 0 > 0). So you can delete even more tests.</pre></blockquote><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">I thought we could enable this tests later?</tt><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>Could you please examine those tests. If they are valid, simply uncomment them.</div><div>If not so - remove. Do it in a separate patch/commit pls.</div><blockquote type="cite" class=""><div class=""><blockquote type="cite" cite="mid:F7CB4F08-B647-444D-A028-C6BB6954E6AE@tarantool.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""><pre class="moz-quote-pre" wrap="">Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define:
I guess it is related to this patch. Seems that it is turned off, so I
assume we can delete it alongside with code under it.
</pre></blockquote><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">Yes, it turned off currently, but it may be turned on. This option also enables</tt><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""><br class=""></tt><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">UPDATE + LIMIT/ORDER BY statements and all code under 'define' appplies</tt><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""><br class=""></tt><tt style="caret-color: rgb(0, 0, 0); font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class="">to this functionality as well, so firstly I decided not to delete it.<span class="Apple-converted-space"> </span></tt><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration: none;" class=""></div></blockquote><br class=""></div><div>I really doubt that some day we will do it. LIMIT is non-ansi extension.</div><div>For example Oracle doesn’t support it at all. I guess this is a reason</div><div>why we got rid of delete+limit. Lets remove it as well.</div><br class=""></body></html>