<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<blockquote type="cite"
cite="mid:F7CB4F08-B647-444D-A028-C6BB6954E6AE@tarantool.org">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On 4 Feb 2019, at 18:34, Ivan Koptelov <a class="moz-txt-link-rfc2396E" href="mailto:ivan.koptelov@tarantool.org"><ivan.koptelov@tarantool.org></a> wrote:
Removes obsolete tests on ORDER BY/LIMIT + DELETE. This
functionality was not supported for some time, but a few tests
were still existing.
Closes #2172
---
Branch <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete">https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete</a>
Issue <a class="moz-txt-link-freetext" href="https://github.com/tarantool/tarantool/issues/2172">https://github.com/tarantool/tarantool/issues/2172</a>
test/sql-tap/e_delete.test.lua | 188 -----------------------------------------
1 file changed, 188 deletions(-)
diff --git a/test/sql-tap/e_delete.test.lua b/test/sql-tap/e_delete.test.lua
index 84a4e0a22..0a81eb3bd 100755
--- a/test/sql-tap/e_delete.test.lua
+++ b/test/sql-tap/e_delete.test.lua
@@ -305,194 +305,6 @@ if (0 > 0) then
DELETE FROM t8 NOT INDEXED WHERE a=5;
END;]], {"NOT INDEXED"}},
})
- -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses (described
- -- below) are unsupported for DELETE statements within triggers.
- —
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
If I’m not mistaken, tests starting from e_delete-2.0 are disabled
(under if 0 > 0). So you can delete even more tests.</pre>
</blockquote>
<tt>I thought we could enable this tests later?</tt><br>
<blockquote type="cite"
cite="mid:F7CB4F08-B647-444D-A028-C6BB6954E6AE@tarantool.org">
<pre class="moz-quote-pre" wrap="">
Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define:
I guess it is related to this patch. Seems that it is turned off, so I
assume we can delete it alongside with code under it.
</pre>
</blockquote>
<tt>Yes, it turned off currently, but it may be turned on. This
option also enables</tt><tt><br>
</tt><tt>UPDATE + LIMIT/ORDER BY statements and all code under
'define' appplies</tt><tt><br>
</tt><tt>to this functionality as well, so firstly I decided not to
delete it. </tt><br>
<br>
</body>
</html>