<HTML><BODY>Hello<br><br>I've rebased on 2.1<br>BUILD: <a href="https://travis-ci.org/tarantool/tarantool/builds/460238498">https://travis-ci.org/tarantool/tarantool/builds/460238498</a> <br>BRANCH: <a href="https://github.com/tarantool/tarantool/tree/sergw/enable-parallel-test-wal-off-clean-2.1">https://github.com/tarantool/tarantool/tree/sergw/enable-parallel-test-wal-off-clean-2.1</a> <br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Среда, 19 сентября 2018, 19:57 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15373762690000000118_BODY">Hi!<br>
<br>
Comments are below.<br>
<br>
WBR, Alexander Turenko.<br>
<br>
Maybe we should place the fix on top of 1.9. I asked Kostya O. and<br>
Kirill Yu. about that in the chat, please ping them and proceed<br>
appropriately.<br>
<br>
> enable parallel mode for wall_off tests<br>
<br>
wall -> wal<br>
<br>
> diff --git a/test/wal_off/lua.test.lua b/test/wal_off/lua.test.lua<br>
> index 7daf9f3f6..02ec9e795 100644<br>
> --- a/test/wal_off/lua.test.lua<br>
> +++ b/test/wal_off/lua.test.lua<br>
> @@ -1,5 +1,6 @@<br>
> env = require('test_run')<br>
> test_run = env.new()<br>
> +test_run:cmd("restart server default with cleanup=1")<br>
<br>
So the approach is to restart the server with clean up for each tests.<br>
It will slows down the execution. The another way you propose (w/ spaces<br>
renaming) seems to be better for me.<br>
<br>
Anyway, you don't describe a reason why exactly this is needed. How we<br>
can meet an inconsistent state if a server was not restarted or<br>
restarted with clean up? I propose to describe problems you fix in the<br>
commit message, otherwise I'll need to investigate the issue again after<br>
you to understand it and give the review.<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Sergei Voronezhskii<br></BODY></HTML>