<HTML><BODY><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Воскресенье, 21 октября 2018, 7:40 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15400968340000000556_BODY">> fio.basename(snaps[1], '.snap') >= fio.basename(xlogs[1], '.xlog')<br>
> <br>
> -- gh-2780 check that scheduled snapshots are performed<br>
> -fiber.sleep(3 * PERIOD)<br>
> --- check that it's not first snapshot<br>
> -test_run:grep_log("default", "saving snapshot", 400) == nil<br>
> -test_run:grep_log("default", "making snapshot", 400) ~= nil<br>
> +test_run:wait_log("default", "making snapshot", 400, 1.0 + PERIOD)<br>
> <br>
> -- restore default options<br>
> box.cfg{checkpoint_interval = 3600 * 4, checkpoint_count = 4 }<br>
<br>
Cite from the previous review:<br>
<br>
> > -- gh-2780 check that scheduled snapshots are performed<br>
> > -fiber.sleep(3 * PERIOD)<br>
> > -- check that it's not first snapshot<br>
> > -test_run:grep_log("default", "saving snapshot", 400) == nil<br>
> > -test_run:grep_log("default", "making snapshot", 400) ~= nil<br>
> > +wait_cond(function() return test_run:grep_log("default", "saving snapshot", 400) == nil end)<br>
> > +wait_cond(function() return test_run:grep_log("default", "making snapshot", 400) ~= nil end)<br>
<br>
> Now we don't check that 'saving snapshot' does not appear during some<br>
> time period. Maybe we should check it after 'making snapshot'.<br>
<br>
It seems you decided to remove the check for some reason you don't mention in<br>
the commit message. Am I missed something obvious?<br>
<br>
In the previous message I just stated that **your** (previous) version of the<br>
patch does not check for 'saving snapshot' while the original case does.<br>
<br>
WBR, Alexander Turenko.<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>Fixed<br><br>
<br>-- <br>Sergei Voronezhskii<br></BODY></HTML>