<HTML><BODY><br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Воскресенье, 21 октября 2018, 23:41 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br><br><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15401544620000000680_BODY">Ok except minor comments below.<br><br>
It would be glab if you'll answer to review messages, cite reviewer<br>
comments and answer what was changed or why it didn't changed. It is<br>
hard to manually track all questions were raised, esp. when the patch is<br>
relatively big.<br><br>
For small changes (eps. for a relatively big patch) you can just answer<br>
for comments. Ideally also attach diff from the previous version at end<br>
of the email (just call `git diff` before commit your changes and<br>
paste). I can see the whole diff on the branch and paste related hunks<br>
to comment it. Other reviewers can ask you to paste the whole new diff<br>
explicitly, I personally prefer to run git diff and paste things I want<br>
to comment.<br><br>
WBR, Alexander Turenko.<br><br>
On Fri, Oct 19, 2018 at 07:17:17PM +0300, Sergei Voronezhskii wrote:<br>
> - at the end of tests which create any replication config need to call:<br>
> * `test_run:cmd('delete server ...')` removes server object<br>
> from `TestState.servers` list, this behaviour was taken<br>
> from `test_run:drop_cluster()` function<br><br>
Please, indent it like so (for ease reading):<br><br>
- xxx<br>
* yyy<br>
zzz<br>
aaa<br>
- fff<br>
eee<br>
* ggg<br>
hhh</div></div></div></div></blockquote>fixed<br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_15401544620000000680_BODY"><br>
> diff --git a/test/replication/local_spaces.test.lua b/test/replication/local_spaces.test.lua<br>
> index 06e2b0bd2..633cc9f1a 100644<br>
> --- a/test/replication/local_spaces.test.lua<br>
> +++ b/test/replication/local_spaces.test.lua<br>
> @@ -76,6 +76,7 @@ box.space.test3:select()<br>
> test_run:cmd("switch default")<br>
> test_run:cmd("stop server replica")<br>
> test_run:cmd("cleanup server replica")<br>
> +test_run:cleanup_cluster()<br>
> box.schema.user.revoke('guest', 'replication')<br>
> <br>
> s1:select()<br><br>
Missed test_run:cmd("delete server replica")?<br></div></div></div></div></blockquote>
fixed<br>
<br>-- <br>Sergei Voronezhskii<br></BODY></HTML>