<HTML><BODY><p style='margin-top: 0px;' dir="ltr">Hello! Thank you for review! My answer below.</p>
<p dir="ltr">On 10/12/2018 03:05 AM, Vladislav<br>
Shpilevoy wrote:<br>
>Thanks<br>
for the fixes! See 1 comment below. <br>
>>diff --git a/src/box/lua/upgrade.lua<br>
b/src/box/lua/upgrade.lua <br>
>> index d9c2ae4..66dcef4 100644 <br>
>> --- a/src/box/lua/upgrade.lua <br>
>> +++ b/src/box/lua/upgrade.lua <br>
>> @@ -578,6 +578,27 @@ local function upgrade_to_2_1_0() <br>
>> box.space._schema:format(format) <br>
>> end <br>
>>+--------------------------------------------------------------------------------<br>
<br>
>> +-- Tarantool 2.1.1 <br>
>>+--------------------------------------------------------------------------------<br>
<br>
>> + <br>
>> +function update_collation_strength_field() <br>
>> + local _collation = box.space[box.schema.COLLATION_ID] <br>
>> + for _, collation in ipairs(_collation:select()) do <br>
>> + if (collation.opts.strength == nil) then <br>
>> + local new_collation =<br>
_collation:get{collation.id}:totable() <br>
>> + new_collation[6].strength = 'identical' <br>
>> + _collation:delete{collation.id} <br>
>> + _collation:insert(new_collation) <br>
> Why did you remove replace from my diff and replaced it with <br>
> delete + insert? collation.id is a primary index and it is the <br>
> same in the new and old collation. It makes no sense to do delete<br>
+ <br>
> insert, when you can do one replace. <br>
Replace couldn't be used in space box.space._collation:<br>
tarantool> function update_collation_strength_field()<br>
> local _collation =<br>
box.space[box.schema.COLLATION_ID]<br>
> for _, collation in ipairs(_collation:select()) do<br>
> if (collation.opts.strength == nil) then<br>
> local new_collation =<br>
_collation:get{collation.id}:totable()<br>
> new_collation[6].strength = 'identical'<br>
> _collation:replace(new_collation)<br>
> end<br>
> end<br>
> end<br>
---<br>
...<br>
tarantool> update_collation_strength_field()<br>
---<br>
- error: collation does not support alter<br>
...<br>
>>+ end <br>
>> + end <br>
>> +end <br>
>> + <br>
>> +local function upgrade_to_2_1_1() <br>
>> + update_collation_strength_field() <br>
>> +end <br>
>> + <br>
>> + </p>
</BODY></HTML>