<HTML><BODY>Hi!<br><br>I've amended the commit message.<br>BRANCH: https://github.com/tarantool/tarantool/tree/sergw/enable-parallel-test-wal-off-clean<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Суббота, 22 сентября 2018, 4:44 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15375806570000000326_BODY">Hi!<br>
<br>
Thanks for the investigation.<br>
<br>
The diff looks good for me and works for me. I have minor comments for<br>
the commit message wording. I'll leave my comments below and the patch<br>
is not needed to re-review with me: please, proceed with Vova and<br>
Kirill.<br>
<br>
Vova, can you please confirm that memtx_memory option should be<br>
increased in the test? I mean confirm that it is the test problem and is<br>
not a problem of tarantool itself.<br>
<br>
WBR, Alexander Turenko.<br>
<br>
On Fri, Sep 21, 2018 at 03:44:42PM +0300, Sergei Voronezhskii wrote:<br>
> Use the proper way to cleanup tests.<br>
<br>
'Use the proper way to cleanup tests' is too common and does not give a<br>
reader useful information. It also cannot be a title of the list below,<br>
because not all items below are about clean up. Proposed to remove the<br>
sentence.<br>
<br>
> - tuple + lua needs more defragmented memory<br>
<br>
Proposed: memtx_memory is increased, because the test '{TEST NAME HERE}'<br>
after '{TEST NAME HERE}' failed with the error '{ERROR HERE}' despite<br>
collectgarbage('collect') calls after cases with huge/many tuples. The<br>
statistics before the allocation fail gives the following values:<br>
{VALUES HERE}. The reason of the fail seems to be a slab memory<br>
fragmentation. It is not clear for now whether we should consider this<br>
as a tarantool issue.<br>
<br>
> - snapshot_stress checks for count of checkpoints<br>
<br>
Proposed: 'snapshot_stress' test counts snapshot files present in the<br>
working directory and can reach the default 'checkpoint_count' value (2)<br>
if a previous test write its snapshots before.<br>
<br>
> - need to cleanup default because of some tests dont drop spaces<br>
> <br>
<br>
Proposed: restarting the default server w/o cleaning a working directory<br>
can leave a snapshot that holds a state saved at the middle of a test,<br>
before dropping of the space 'tweedledum' (because WAL is disabled),<br>
that can cause the error '{ERROR HERE}' for a following test.<br>
<br>
Sorry for nitpicking, that was to have a clear problem statements and<br>
don't reinvestigate it again in the future (if something like occurs).<br>
<br>
> Part of #2436<br>
> ---<br>
> <br>
> BRANCH: sergw/enable-parallel-test-wal-off-clean<br>
> <br>
> test/wal_off/oom.result | 2 +-<br>
> test/wal_off/oom.test.lua | 2 +-<br>
> test/wal_off/suite.ini | 2 +-<br>
> test/wal_off/tuple.result | 2 +-<br>
> test/wal_off/tuple.test.lua | 2 +-<br>
> test/wal_off/wal.lua | 5 +++--<br>
> 6 files changed, 8 insertions(+), 7 deletions(-)<br>
> <br>
> diff --git a/test/wal_off/oom.result b/test/wal_off/oom.result<br>
> index c47d16c46..90bc53d22 100644<br>
> --- a/test/wal_off/oom.result<br>
> +++ b/test/wal_off/oom.result<br>
> @@ -4,7 +4,7 @@ env = require('test_run')<br>
> test_run = env.new()<br>
> ---<br>
> ...<br>
> -test_run:cmd('restart server default')<br>
> +test_run:cmd('restart server default with cleanup=1')<br>
> test_run:cmd("push filter 'error: Failed to allocate [0-9]+ ' to 'error: Failed to allocate <NUM> '")<br>
> ---<br>
> - true<br>
> diff --git a/test/wal_off/oom.test.lua b/test/wal_off/oom.test.lua<br>
> index 5c0ab8e73..8e6e14046 100644<br>
> --- a/test/wal_off/oom.test.lua<br>
> +++ b/test/wal_off/oom.test.lua<br>
> @@ -1,6 +1,6 @@<br>
> env = require('test_run')<br>
> test_run = env.new()<br>
> -test_run:cmd('restart server default')<br>
> +test_run:cmd('restart server default with cleanup=1')<br>
> test_run:cmd("push filter 'error: Failed to allocate [0-9]+ ' to 'error: Failed to allocate <NUM> '")<br>
> <br>
> space = box.schema.space.create('tweedledum')<br>
> diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini<br>
> index ad19eab10..cbb7cb341 100644<br>
> --- a/test/wal_off/suite.ini<br>
> +++ b/test/wal_off/suite.ini<br>
> @@ -2,4 +2,4 @@<br>
> core = tarantool<br>
> script = wal.lua<br>
> description = tarantool/box, wal_mode = none<br>
> -is_parallel = False<br>
> +is_parallel = True<br>
> diff --git a/test/wal_off/tuple.result b/test/wal_off/tuple.result<br>
> index fa431e203..6ea3814fc 100644<br>
> --- a/test/wal_off/tuple.result<br>
> +++ b/test/wal_off/tuple.result<br>
> @@ -4,7 +4,7 @@ env = require('test_run')<br>
> test_run = env.new()<br>
> ---<br>
> ...<br>
> -test_run:cmd("restart server default")<br>
> +test_run:cmd('restart server default with cleanup=1')<br>
> -- <br>
> -- Test various tuple bugs which do not require a write ahead log.<br>
> -- <br>
> diff --git a/test/wal_off/tuple.test.lua b/test/wal_off/tuple.test.lua<br>
> index 19415a92d..6962f35ad 100644<br>
> --- a/test/wal_off/tuple.test.lua<br>
> +++ b/test/wal_off/tuple.test.lua<br>
> @@ -1,6 +1,6 @@<br>
> env = require('test_run')<br>
> test_run = env.new()<br>
> -test_run:cmd("restart server default")<br>
> +test_run:cmd('restart server default with cleanup=1')<br>
> -- <br>
> -- Test various tuple bugs which do not require a write ahead log.<br>
> -- <br>
> diff --git a/test/wal_off/wal.lua b/test/wal_off/wal.lua<br>
> index 6e4afbe4d..4005e78cd 100644<br>
> --- a/test/wal_off/wal.lua<br>
> +++ b/test/wal_off/wal.lua<br>
> @@ -2,9 +2,10 @@<br>
> <br>
> box.cfg{<br>
> listen = os.getenv("LISTEN"),<br>
> - memtx_memory = 107374182,<br>
> + memtx_memory = 157374182,<br>
> pid_file = "tarantool.pid",<br>
> - wal_mode = "none"<br>
> + wal_mode = "none",<br>
> + checkpoint_count = 100<br>
> }<br>
> <br>
> require('console').listen(os.getenv('ADMIN'))<br>
> -- <br>
> 2.18.0<br>
> <br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Sergei Voronezhskii<br></BODY></HTML>