<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">8 авг. 2018 г., в 13:58, Vladimir Davydov <<a href="mailto:vdavydov.dev@gmail.com" class="">vdavydov.dev@gmail.com</a>> написал(а):</div><br class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Wed, Aug 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""><br class=""><blockquote type="cite" class="">7 авг. 2018 г., в 19:50, Vladimir Davydov <<a href="mailto:vdavydov.dev@gmail.com" class="">vdavydov.dev@gmail.com</a>> написал(а):<br class=""><br class="">On Mon, Aug 06, 2018 at 05:14:05PM +0300, Sergey Petrenko wrote:<br class=""><blockquote type="cite" class="">diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua<br class="">index c05e52165..27c1a4821 100644<br class="">--- a/test/replication/misc.test.lua<br class="">+++ b/test/replication/misc.test.lua<br class="">@@ -81,3 +81,15 @@ test_run:cmd("switch default")<br class="">test_run:drop_cluster(SERVERS)<br class=""><br class="">box.schema.user.revoke('guest', 'replication')<br class="">+<br class="">+-- gh-3510 assertion failure in replica_on_applier_disconnect()<br class="">+test_run:cmd('create server er_load1 with script="replication/er_load1.lua"')<br class="">+test_run:cmd('create server er_load2 with script="replication/er_load2.lua"')<br class="">+test_run:cmd('start server er_load1 with wait=False, wait_load=False')<br class="">+test_run:cmd('start server er_load2 with wait=False, wait_load=False')<br class="">+require('fiber').sleep(0.5)<br class="">+test_run:cmd('stop server er_load1')<br class="">+require('fiber').sleep(1)<br class=""></blockquote><br class=""><kostja-mode><br class="">These sleep()'s are way too long. They will make our tests run forever.<br class="">Please change to 0.00001 or smaller or rewrite the test so that you do<br class="">not need them.<br class=""></kostja-mode><br class=""></blockquote><br class="">Hi! Thank you for review.<br class="">Fixed. Here’s the new diff:<br class=""><br class="">src/box/<a href="http://replication.cc" class="">replication.cc</a> | 4 ++++<br class="">test/replication/er_load.lua | 25 +++++++++++++++++++++++++<br class="">test/replication/er_load1.lua | 1 +<br class="">test/replication/er_load2.lua | 1 +<br class="">test/replication/misc.result | 32 ++++++++++++++++++++++++++++++++<br class="">test/replication/misc.test.lua | 12 ++++++++++++<br class="">6 files changed, 75 insertions(+)<br class="">create mode 100644 test/replication/er_load.lua<br class="">create mode 120000 test/replication/er_load1.lua<br class="">create mode 120000 test/replication/er_load2.lua<br class=""><br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">With your patch replication/on_replace test hangs on Travis CI for</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">test/coverage targets (I tried to restart, but it doesn't help).</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Actually, it hangs on my local machine too (debug build). Please fix.</span></div></blockquote>Hi! This happens due to a bug in test-run.</div><div>I filed a ticket (<a href="https://github.com/tarantool/test-run/issues/109" class="">https://github.com/tarantool/test-run/issues/109</a>).</div><div>When it’s fixed, my test should pass no problem. So we have to wait for now.</div><br class=""></body></html>